Issue 5543049: code review 5543049: weekly.2012-01-15

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5543049: code review 5543049: weekly.2012-01-15 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by adg

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, dsymonds, r, niemeyer

Visibility:
Public.

Patch Set 2 : diff -r e8bfc2f65c2b https://go.googlecode.com/hg #

Patch Set 3 : diff -r f63e838fc121 https://go.googlecode.com/hg #

Total comments: 2

Patch Set 4 : diff -r f63e838fc121 https://go.googlecode.com/hg #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -1 line)			Patch
	M	.hgtags	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	doc/devel/weekly.html	View	1 2 3	1 chunk	+117 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years, 3 months ago (2012-01-13 02:36:43 UTC) #1

adg

Hello golang-dev@googlegroups.com, dsymonds@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 3 months ago (2012-01-15 22:35:05 UTC) #4

niemeyer

http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html#newcode17 doc/devel/weekly.html:17: <h2 id="2012-01-13">2012-01-13</h2> 15?

12 years, 3 months ago (2012-01-15 22:44:02 UTC) #6

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=354b17404643 *** weekly.2012-01-15 R=golang-dev, dsymonds, r, n13m3y3r CC=golang-dev http://codereview.appspot.com/5543049 http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html File doc/devel/weekly.html ...

12 years, 3 months ago (2012-01-15 22:45:29 UTC) #7

adg

12 years, 3 months ago (2012-01-15 22:49:05 UTC) #8

Good catch, thanks!

On 16 January 2012 09:44,  <n13m3y3r@gmail.com> wrote:
>
> http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html
> File doc/devel/weekly.html (right):
>
>
http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html#newcode17
> doc/devel/weekly.html:17: <h2 id="2012-01-13">2012-01-13</h2>
> 15?
>
> http://codereview.appspot.com/5543049/

Expand All Messages | Collapse All Messages