Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)

Issue 5543049: code review 5543049: weekly.2012-01-15 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by adg
Modified:
10 years ago
Reviewers:
CC:
golang-dev, dsymonds, r, niemeyer
Visibility:
Public.

Description

weekly.2012-01-15

Patch Set 1 #

Patch Set 2 : diff -r e8bfc2f65c2b https://go.googlecode.com/hg #

Patch Set 3 : diff -r f63e838fc121 https://go.googlecode.com/hg #

Total comments: 2

Patch Set 4 : diff -r f63e838fc121 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 3 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 8
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
10 years ago (2012-01-13 02:36:43 UTC) #1
dsymonds
LGTM
10 years ago (2012-01-13 05:21:48 UTC) #2
r
LGTM
10 years ago (2012-01-13 06:13:52 UTC) #3
adg
Hello golang-dev@googlegroups.com, dsymonds@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years ago (2012-01-15 22:35:05 UTC) #4
dsymonds
LGTM
10 years ago (2012-01-15 22:41:11 UTC) #5
niemeyer
http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html#newcode17 doc/devel/weekly.html:17: <h2 id="2012-01-13">2012-01-13</h2> 15?
10 years ago (2012-01-15 22:44:02 UTC) #6
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=354b17404643 *** weekly.2012-01-15 R=golang-dev, dsymonds, r, n13m3y3r CC=golang-dev http://codereview.appspot.com/5543049 http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html File doc/devel/weekly.html ...
10 years ago (2012-01-15 22:45:29 UTC) #7
adg
10 years ago (2012-01-15 22:49:05 UTC) #8
Good catch, thanks!

On 16 January 2012 09:44,  <n13m3y3r@gmail.com> wrote:
>
> http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html
> File doc/devel/weekly.html (right):
>
>
http://codereview.appspot.com/5543049/diff/2005/doc/devel/weekly.html#newcode17
> doc/devel/weekly.html:17: <h2 id="2012-01-13">2012-01-13</h2>
> 15?
>
> http://codereview.appspot.com/5543049/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b