Remove calls to new when modifying shader constants.

Remove calls to new when modifying shader constants.

There were some unnecessary temporary copies we can remove, and the rest have a maximum size so we can allocate them on the stack.

BUG=276
TEST=

Committed: https://code.google.com/p/angleproject/source/detail?r=961

[nicolas, 2012-01-19 22:55:26]

Getting rid of the unnecessary copies looks good to me.

The cases where you use the maximum size seem to require overflow protection.
Perhaps you could validate the glUniform function's count parameter against
getMaximum[Fragment|Vertex]UniformVectors() and reuse MAX_VERTEX_UNIFORM_VECTORS
instead of adding D3D9_MAX_FLOAT_REGISTERS.

[nicolas, 2012-01-20 15:25:20]

We had a closer look at it, and it seems the count parameter for applyUniform
calls will never be larger than what the hardware supports. So your approach is
fine without requiring extra bounds checks (although and assert wouldn't hurt).

My suggestion to use MAX_VERTEX_UNIFORM_VECTORS is incorrect but perhaps you can
still move D3D9_MAX_FLOAT_REGISTERS and such to Context.h and define
MAX_VERTEX_UNIFORM_VECTORS in terms of it.

[John Bauman, 2012-01-21 01:29:18]

On 2012/01/20 15:25:20, nicolas wrote:
> We had a closer look at it, and it seems the count parameter for applyUniform
> calls will never be larger than what the hardware supports. So your approach
is
> fine without requiring extra bounds checks (although and assert wouldn't
hurt).
> 
> My suggestion to use MAX_VERTEX_UNIFORM_VECTORS is incorrect but perhaps you
can
> still move D3D9_MAX_FLOAT_REGISTERS and such to Context.h and define
> MAX_VERTEX_UNIFORM_VECTORS in terms of it.

Ok, added some asserts, moved the location of the defines of D3D9_MAX_*, and
made MAX_VERTEX_UNIFORM_VECTORS depend on D3D9_MAX_FLOAT_CONSTANTS.

[nicolas, 2012-01-23 21:10:59]

On 2012/01/21 01:29:18, John Bauman wrote:
> Ok, added some asserts, moved the location of the defines of D3D9_MAX_*, and
> made MAX_VERTEX_UNIFORM_VECTORS depend on D3D9_MAX_FLOAT_CONSTANTS.

Thanks, looks great!

[dgkoch, 2012-01-23 21:39:08]

LGTM