Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1421)

Issue 553580043: mf: use python scripting for generating Emmentaler fonts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by hanwenn
Modified:
2 months, 4 weeks ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

mf: use python scripting for generating Emmentaler fonts This gets rid of the ugly generated FontForge scripts, and avoids intermediate files. Remove sequencing on |pfb . This was introduced in e6a5019 (Jun 28 2012, "Clean fonts and docs makefiles"). The race conditions were fixed in f6dc5e (May 15 2014, "Generate a .pe script for one design size at a time.") Remove XXX.fontname files. They appear to be unused. Remove XXX.otf-table files. The script reads .lips directly. In mf-to-table: * Remove support for .enc files. Encodings are hardcoded in ps/encodingdefs.ps these days * Remove support for .dep files. They are generated from a shell rule in metafont-vars.make

Patch Set 1 #

Total comments: 8

Patch Set 2 : read .lisp #

Patch Set 3 : enc #

Patch Set 4 : mf-to-table #

Patch Set 5 : fix #

Patch Set 6 : werner #

Patch Set 7 : getopt #

Patch Set 8 : test build #

Patch Set 9 : rebase #

Patch Set 10 : ubuntu 16.04 compat #

Total comments: 2

Patch Set 11 : rebase #

Patch Set 12 : lemzwerg #

Patch Set 13 : lemzwerg #

Patch Set 14 : remove grouped rule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -327 lines) Patch
M mf/GNUmakefile View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +29 lines, -38 lines 0 comments Download
M mf/README View 1 chunk +6 lines, -8 lines 0 comments Download
D mf/emmentaler-brace.pe.in View 1 chunk +0 lines, -85 lines 0 comments Download
A mf/gen-emmentaler-brace.fontforge.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +76 lines, -0 lines 0 comments Download
A mf/gen-emmentaler.fontforge.py View 1 2 3 4 5 1 chunk +82 lines, -0 lines 0 comments Download
D scripts/build/gen-emmentaler-scripts.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -103 lines 0 comments Download
M scripts/build/mf-to-table.py View 1 2 3 4 5 6 7 4 chunks +7 lines, -93 lines 0 comments Download

Messages

Total messages: 25
hanwenn
read .lisp
4 months, 1 week ago (2020-02-29 21:03:57 UTC) #1
hanwenn
enc
4 months, 1 week ago (2020-02-29 21:29:11 UTC) #2
lemzwerg
LGTM; some minor nits https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile#newcode130 mf/GNUmakefile:130: $(outdir)/emmentaler-brace.otf: emmentaler-brace.fontforge.py $(outdir)/emmentaler-brace.otf-table \ maybe ...
4 months, 1 week ago (2020-02-29 21:33:11 UTC) #3
hanwenn
mf-to-table
4 months, 1 week ago (2020-02-29 22:08:25 UTC) #4
hanwenn
fix
4 months, 1 week ago (2020-02-29 22:24:51 UTC) #5
hanwenn
https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile#newcode130 mf/GNUmakefile:130: $(outdir)/emmentaler-brace.otf: emmentaler-brace.fontforge.py $(outdir)/emmentaler-brace.otf-table \ On 2020/02/29 21:33:10, lemzwerg wrote: ...
4 months, 1 week ago (2020-02-29 22:31:30 UTC) #6
hanwenn
werner
4 months, 1 week ago (2020-02-29 22:31:53 UTC) #7
hanwenn
getopt
4 months, 1 week ago (2020-02-29 22:47:29 UTC) #8
lemzwerg
> > Can we assume that FontForge's python support and is > > always enabled? ...
4 months, 1 week ago (2020-02-29 22:53:43 UTC) #9
hanwenn
test build
4 months, 1 week ago (2020-03-01 10:06:42 UTC) #10
hanwenn
rebase
4 months, 1 week ago (2020-03-01 17:57:27 UTC) #11
hahnjo
On 2020/02/29 22:53:43, lemzwerg wrote: > > > Can we assume that FontForge's python support ...
4 months, 1 week ago (2020-03-02 09:56:17 UTC) #12
hanwenn
ubuntu 16.04 compat
4 months, 1 week ago (2020-03-03 19:48:56 UTC) #13
hanwenn
rebase
3 months, 2 weeks ago (2020-03-27 18:25:04 UTC) #14
lemzwerg
https://codereview.appspot.com/553580043/diff/571810043/mf/gen-emmentaler-brace.fontforge.py File mf/gen-emmentaler-brace.fontforge.py (right): https://codereview.appspot.com/553580043/diff/571810043/mf/gen-emmentaler-brace.fontforge.py#newcode40 mf/gen-emmentaler-brace.fontforge.py:40: # mergeFonts takes a font, but this is a ...
3 months, 2 weeks ago (2020-03-27 21:38:16 UTC) #15
hanwenn
lemzwerg
3 months, 2 weeks ago (2020-03-29 13:31:27 UTC) #16
hanwenn
lemzwerg
3 months, 2 weeks ago (2020-03-29 13:32:25 UTC) #17
hanwenn
https://codereview.appspot.com/553580043/diff/571810043/mf/gen-emmentaler-brace.fontforge.py File mf/gen-emmentaler-brace.fontforge.py (right): https://codereview.appspot.com/553580043/diff/571810043/mf/gen-emmentaler-brace.fontforge.py#newcode40 mf/gen-emmentaler-brace.fontforge.py:40: # mergeFonts takes a font, but this is a ...
3 months, 2 weeks ago (2020-03-29 13:32:34 UTC) #18
hanwenn
remove grouped rule
3 months, 1 week ago (2020-03-29 16:45:12 UTC) #19
hanwenn
Jonas, what is the status of 2.21.0 ?
3 months, 1 week ago (2020-04-02 20:32:39 UTC) #20
dak
On 2020/04/02 20:32:39, hanwenn wrote: > Jonas, what is the status of 2.21.0 ? I ...
3 months, 1 week ago (2020-04-02 21:04:06 UTC) #21
thomasmorley651
On 2020/04/02 21:04:06, dak wrote: > On 2020/04/02 20:32:39, hanwenn wrote: > > Jonas, what ...
3 months, 1 week ago (2020-04-02 21:09:57 UTC) #22
dak
On 2020/04/02 21:09:57, thomasmorley651 wrote: > On 2020/04/02 21:04:06, dak wrote: > > On 2020/04/02 ...
3 months, 1 week ago (2020-04-02 21:20:58 UTC) #23
thomasmorley651
On 2020/04/02 21:20:58, dak wrote: > On 2020/04/02 21:09:57, thomasmorley651 wrote: > > On 2020/04/02 ...
3 months, 1 week ago (2020-04-02 21:27:55 UTC) #24
hanwenn
2 months, 4 weeks ago (2020-04-13 21:02:44 UTC) #25
commit 2d40ef8ced63607cc1a9b2a0bc6a1fd1122af8c4
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Fri Mar 27 19:20:32 2020 +0100

    mf: use python scripting for generating Emmentaler fonts
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b