Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(280)

Issue 553430047: Some py3 fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by hanwenn
Modified:
4 years, 3 months ago
Reviewers:
lemzwerg, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Some py3 fixes * 0777 should be spelled as 0o777. We omit it as it is the mkdir default. * print needs parentheses. Use sys.stderr.write instead.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M python/langdefs.py View 1 chunk +1 line, -1 line 0 comments Download
M python/lilylib.py View 2 chunks +10 lines, -11 lines 1 comment Download
M scripts/lilypond-book.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
lemzwerg
LGTM https://codereview.appspot.com/553430047/diff/573430051/python/lilylib.py File python/lilylib.py (right): https://codereview.appspot.com/553430047/diff/573430051/python/lilylib.py#newcode257 python/lilylib.py:257: sys.stderr.write('command failed: %s\n' % cmd) With space before ...
4 years, 3 months ago (2020-01-25 19:08:03 UTC) #1
hahnjo
While probably correct, I strongly object to this patch. I've been working on migration to ...
4 years, 3 months ago (2020-01-26 12:40:00 UTC) #2
hanwenn
what is the status of your work?
4 years, 3 months ago (2020-01-26 13:27:25 UTC) #3
hanwenn
On 2020/01/26 13:27:25, hanwenn wrote: > what is the status of your work? leaving Jonas ...
4 years, 3 months ago (2020-01-26 13:29:25 UTC) #4
hahnjo
On 2020/01/26 13:27:25, hanwenn wrote: > what is the status of your work? I think ...
4 years, 3 months ago (2020-01-26 13:31:52 UTC) #5
hanwenn
David? Is there a git branch that we can check out? For testing, I think ...
4 years, 3 months ago (2020-01-26 13:38:41 UTC) #6
hahnjo
4 years, 3 months ago (2020-01-26 13:41:40 UTC) #7
Message was sent while issue was closed.
On 2020/01/26 13:38:41, hanwenn wrote:
> David?
> 
> Is there a git branch that we can check out? For testing, I think it's
> better than downloading patches from rietveld.

Well, maybe read
https://lists.gnu.org/archive/html/lilypond-devel/2020-01/msg00415.html ?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b