Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(346)

Issue 5533077: code review 5533077: sql: fix potential corruption in QueryRow.Scan into a *... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by bradfitz
Modified:
9 years ago
Reviewers:
CC:
golang-dev, adg
Visibility:
Public.

Description

sql: fix potential corruption in QueryRow.Scan into a *[]byte Fixes issue 2622

Patch Set 1 #

Patch Set 2 : diff -r c6318b5115e5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c6318b5115e5 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 4 : diff -r 29382b5af719 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -9 lines) Patch
M src/pkg/exp/sql/fakedb_test.go View 1 2 3 chunks +25 lines, -0 lines 0 comments Download
M src/pkg/exp/sql/sql.go View 1 2 3 2 chunks +27 lines, -5 lines 0 comments Download
M src/pkg/exp/sql/sql_test.go View 1 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years ago (2012-01-12 00:52:35 UTC) #1
adg
LGTM http://codereview.appspot.com/5533077/diff/1002/src/pkg/exp/sql/fakedb_test.go File src/pkg/exp/sql/fakedb_test.go (right): http://codereview.appspot.com/5533077/diff/1002/src/pkg/exp/sql/fakedb_test.go#newcode559 src/pkg/exp/sql/fakedb_test.go:559: clone = make([]byte, len(bs)) rc.bytesClone[&bs[0]] = append([]byte{}, bs...) ...
9 years ago (2012-01-12 11:10:30 UTC) #2
bradfitz
9 years ago (2012-01-12 19:23:37 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=8f82e0f84bfe ***

sql: fix potential corruption in QueryRow.Scan into a *[]byte

Fixes issue 2622

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5533077
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b