Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2093)

Issue 5532091: Cleanup of SkPath code to remove SK_OLD_EMPTY_PATH_BEHAVIOR and other (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Stephen Chenney
Modified:
12 years, 11 months ago
Reviewers:
caryclark1, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Cleanup of SkPath code to remove SK_OLD_EMPTY_PATH_BEHAVIOR and other dead code. The patch also renames kAfterClose_SegmentState for the SkPath::Iter class, to kEmptyContour_SegmentState which more accurately reflects the meaning of the state. The Iter can be in that state initially, before anything has been seen, let alone a close. BUG=445 TEST=Covered by existing tests. Committed: https://code.google.com/p/skia/source/detail?r=3074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -47 lines) Patch
M src/core/SkPath.cpp View 10 chunks +6 lines, -47 lines 0 comments Download

Messages

Total messages: 3
reed1
Looks like remove, plus a change for kEmptyContour .... That new code is covered by ...
12 years, 11 months ago (2012-01-18 19:20:41 UTC) #1
Stephen Chenney
On 2012/01/18 19:20:41, reed1 wrote: > Looks like remove, plus a change for kEmptyContour .... ...
12 years, 11 months ago (2012-01-18 19:26:56 UTC) #2
reed1
12 years, 11 months ago (2012-01-18 21:08:44 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b