Issue 5532055: code review 5532055: cmd/go: add -v flag to build and install

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5532055: code review 5532055: cmd/go: add -v flag to build and install (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by rsc

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/go: add -v flag to build and install The -v flag prints the names of packages as they are built/installed. Use -v in make.bash/run.bash to avoid a silent pause during the build while Go code is being compiled.

Patch Set 1 #

Patch Set 2 : diff -r 5c292c9954f0 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 5c292c9954f0 https://code.google.com/p/go/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -9 lines)			Patch
M	src/cmd/go/build.go	View	1	9 chunks	+15 lines, -5 lines	0 comments	Download
M	src/cmd/go/run.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/go/test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/make.bash	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/run.bash	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 3 months ago (2012-01-10 00:27:50 UTC) #1

LGTM http://codereview.appspot.com/5532055/diff/2001/src/cmd/go/build.go File src/cmd/go/build.go (right): http://codereview.appspot.com/5532055/diff/2001/src/cmd/go/build.go#newcode120 src/cmd/go/build.go:120: var installX = cmdInstall.Flag.Bool("x", false, "") it's starting ...

13 years, 3 months ago (2012-01-10 00:41:42 UTC) #2

rsc

13 years, 3 months ago (2012-01-10 00:44:03 UTC) #3

*** Submitted as 44aab7e263cd ***

cmd/go: add -v flag to build and install

The -v flag prints the names of packages as they are built/installed.

Use -v in make.bash/run.bash to avoid a silent pause during
the build while Go code is being compiled.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5532055

Expand All Messages | Collapse All Messages