Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 553010043: Issue 5564: fix conversion warnings in beaming code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by Dan Eble
Modified:
5 months, 2 weeks ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5564/ Changes include preserving sizes and indices as vsize types and adding explicit static casts. Warnings were reported by g++ 9.2.1 on x86_64.

Patch Set 1 #

Patch Set 2 : fix absolute difference of unsigned types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -34 lines) Patch
M lily/beam.cc View 1 7 chunks +20 lines, -8 lines 0 comments Download
M lily/beam-quanting.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M lily/beaming-pattern.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M lily/include/beam.hh View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/include/beam-scoring-problem.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/beaming-pattern.hh View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
6 months ago (2019-10-02 03:07:40 UTC) #1
Dan Eble
5 months, 3 weeks ago (2019-10-10 18:44:35 UTC) #2
fix absolute difference of unsigned types
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b