code review 5523047: gc: fix infinite recursion for embedded interfaces

gc: fix infinite recursion for embedded interfaces

Fixes issue 1909

[lvd, 2012-01-12 09:40:04]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[lvd, 2012-01-12 21:39:45]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-01-12 21:42:02]

what's here lgtm

[lvd, 2012-01-12 21:45:29]

merci. then i'll go fix gcimporter again.

On Thu, Jan 12, 2012 at 22:42, Russ Cox <rsc@golang.org> wrote:
> what's here lgtm

[lvd, 2012-01-16 10:57:43]

Hello rsc@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[lvd, 2012-01-16 10:58:41]

Added gri for the changes to gcimporter.

Again, minimal changes to keep it parsing, but no attempt to actually use the
type info.

On 2012/01/16 10:57:43, lvd wrote:
> Hello mailto:rsc@golang.org, mailto:gri@golang.org (cc:
mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

[gri, 2012-01-16 18:57:26]

FYI.

Otherwise the gcimporter changes LGTM.
- gri

http://codereview.appspot.com/5523047/diff/13002/src/pkg/exp/types/gcimporter.go
File src/pkg/exp/types/gcimporter.go (right):

http://codereview.appspot.com/5523047/diff/13002/src/pkg/exp/types/gcimporter...
src/pkg/exp/types/gcimporter.go:463: // MethodOrEmbedSpec = MethodSpec |
EmbedSpec .
Please make this:

// MethodOrEmbedSpec = Name [ Signature ] .

then it matches the code.

[rsc, 2012-01-17 00:01:59]

LGTM

[lvd, 2012-01-17 09:00:28]

http://codereview.appspot.com/5523047/diff/13002/src/pkg/exp/types/gcimporter.go
File src/pkg/exp/types/gcimporter.go (right):

http://codereview.appspot.com/5523047/diff/13002/src/pkg/exp/types/gcimporter...
src/pkg/exp/types/gcimporter.go:463: // MethodOrEmbedSpec = MethodSpec |
EmbedSpec .
On 2012/01/16 18:57:26, gri wrote:
> Please make this:
> 
> // MethodOrEmbedSpec = Name [ Signature ] .
> 
> then it matches the code.

Done.

http://codereview.appspot.com/5523047/diff/13002/src/pkg/exp/types/gcimporter...
src/pkg/exp/types/gcimporter.go:463: // MethodOrEmbedSpec = MethodSpec |
EmbedSpec .
On 2012/01/16 18:57:26, gri wrote:
> Please make this:
> 
> // MethodOrEmbedSpec = Name [ Signature ] .
> 
> then it matches the code.

Done.

[lvd, 2012-01-17 09:01:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=f1deaf35e1d1 ***

gc: fix infinite recursion for embedded interfaces

Fixes issue 1909

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/5523047

[albert.strasheim, 2012-01-19 15:15:10]

On 2012/01/17 09:01:01, lvd wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=f1deaf35e1d1 ***
> gc: fix infinite recursion for embedded interfaces
> Fixes issue 1909
> R=rsc, gri
> CC=golang-dev
> http://codereview.appspot.com/5523047

I think we've picked up a problem with this change.

http://code.google.com/p/go/issues/detail?id=2741