Issue 5519047: Add G_GNUC_PRINTF for function ibus_text_new_from_printf(), so compiler can check arguments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5519047: Add G_GNUC_PRINTF for function ibus_text_new_from_printf(), so compiler can check arguments. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by Peng

Modified:
14 years, 1 month ago

Reviewers:
Yusuke Sato

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Add G_GNUC_PRINTF for function ibus_text_new_from_printf(), so compiler can check arguments. BUG=None TEST=Manually

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ibustext.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

Yusuke Sato

LGTM++ Can you check if there's more printf-ish vaarg functions?

14 years, 1 month ago (2012-01-06 09:37:28 UTC) #2

Peng

14 years, 1 month ago (2012-01-06 15:17:21 UTC) #3

On 2012/01/06 09:37:28, Yusuke Sato wrote:
> LGTM++
> 
> Can you check if there's more printf-ish vaarg functions?

checked. It is the only one.