Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11189)

Issue 551300043: Issue 5648: Allow user to provide CXXFLAGS on command line (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Dan Eble
Modified:
4 years, 3 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5648/ I've found these changes helpful while experimentally enabling some optional warnings. I'm submitting these on their own because I'm not sure how much longer I'll need to finish up the related warning work. 1: move -Woverloaded-virtual from CXXFLAGS to EXTRA_CXXFLAGS 2: move CXXFLAGS to the end of ALL_CXXFLAGS This allows CXXFLAGS=... on the command line to override flags in ALL_CXXFLAGS. 3: Stop copying FlexLexer.h Leave FlexLexer.h where it is, rather than copying it to $(outdir). As we enable more warnings, we will not want to hear about problems in this file. g++ automatically suppresses warnings for headers found in system include directories (specified with -isystem), so the simple solution is to leave it where it is.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M lily/GNUmakefile View 2 chunks +1 line, -10 lines 0 comments Download
M stepmake/stepmake/c++-vars.make View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1
lemzwerg
4 years, 4 months ago (2019-12-26 09:08:38 UTC) #1
LGTM, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b