Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(281)

Issue 5505060: Use gobject-introspection instead ibus python library (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by Peng
Modified:
14 years ago
Reviewers:
fujiwara
Base URL:
git@github.com:/ibus/ibus-tmpl.git@master
Visibility:
Public.

Description

Use gobject-introspection instead ibus python library BUG=http://code.google.com/p/ibus/issues/detail?id=1384 TEST=python main.py

Patch Set 1 #

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -97 lines) Patch
M engine/Makefile.am View 1 2 chunks +1 line, -2 lines 0 comments Download
M engine/engine.py View 1 6 chunks +48 lines, -35 lines 0 comments Download
D engine/factory.py View 1 1 chunk +0 lines, -39 lines 0 comments Download
M engine/main.py View 1 3 chunks +35 lines, -21 lines 0 comments Download

Messages

Total messages: 3
Peng
14 years ago (2012-01-12 16:02:13 UTC) #1
fujiwara
On 2012/01/12 16:02:13, Peng wrote: lgtm It might be good to replace 2011 with 2012 ...
14 years ago (2012-01-13 01:57:46 UTC) #2
Peng
14 years ago (2012-01-13 02:15:14 UTC) #3
On 2012/01/13 01:57:46, fujiwara wrote:
> On 2012/01/12 16:02:13, Peng wrote:
> 
> lgtm
> 
> It might be good to replace 2011 with 2012 for copyright.

Thanks. BTW, If you have time, please port anthy engine to gi. I plan to remove
ibus python library.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b