Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 5504062: code review 5504062: build: fixes for Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rsc
Modified:
10 years, 7 months ago
Reviewers:
CC:
golang-dev, r, bradfitz
Visibility:
Public.

Description

build: fixes for Windows * work around a linker/cgo bug * do not run deps.bash on Windows unless we need it (cuts a full minute off the build time) * add windows to the list of cgo-enabled targets The gopack problem is issue 2601.

Patch Set 1 #

Patch Set 2 : diff -r 498835bf2505 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 498835bf2505 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
src/cmd/go/build.go View 1 2 5 chunks +15 lines, -3 lines 0 comments Download
src/make.bash View 1 1 chunk +1 line, -0 lines 0 comments Download
src/pkg/go/build/dir.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 7 months ago (2011-12-21 20:46:12 UTC) #1
r
LGTM http://codereview.appspot.com/5504062/diff/2001/src/cmd/go/build.go File src/cmd/go/build.go (right): http://codereview.appspot.com/5504062/diff/2001/src/cmd/go/build.go#newcode583 src/cmd/go/build.go:583: // not sure I want to know. http://golang.org/issue/2601 ...
10 years, 7 months ago (2011-12-21 20:48:38 UTC) #2
bradfitz
Remove the println debugging? On Wed, Dec 21, 2011 at 12:46 PM, <rsc@golang.org> wrote: > ...
10 years, 7 months ago (2011-12-21 20:51:22 UTC) #3
rsc
On Wed, Dec 21, 2011 at 15:51, Brad Fitzpatrick <bradfitz@golang.org> wrote: > Remove the println ...
10 years, 7 months ago (2011-12-21 20:52:01 UTC) #4
rsc
10 years, 7 months ago (2011-12-21 20:57:52 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=f31b4b5afe43 ***

build: fixes for Windows

* work around a linker/cgo bug
* do not run deps.bash on Windows unless we need it
  (cuts a full minute off the build time)
* add windows to the list of cgo-enabled targets

The gopack problem is issue 2601.

R=golang-dev, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5504062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b