code review 5504054: builder: report run time

builder: report run time
dashboard: record run time

[adg, 2011-12-21 03:52:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2011-12-21 04:38:13]

LGTM

I hope we can make that a time.Duration eventually.
Is there a different datastore type we should be using
for that?

[adg, 2011-12-21 04:43:13]

On 21 December 2011 15:38, Russ Cox <rsc@golang.org> wrote:
> LGTM
>
> I hope we can make that a time.Duration eventually.
> Is there a different datastore type we should be using
> for that?

Nope. One we have Go 1 in App Engine it can be renamed to time.Duration.

[adg, 2011-12-21 04:43:18]

*** Submitted as e5e5553aa150 ***

builder: report run time
dashboard: record run time

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5504054

[dsymonds, 2011-12-21 05:48:31]

On Wed, Dec 21, 2011 at 3:42 PM, Andrew Gerrand <adg@golang.org> wrote:

> Nope. One we have Go 1 in App Engine it can be renamed to time.Duration.

No you won't. time.Time will be supported, but datastore doesn't know
anything about time durations.

[adg, 2011-12-21 05:51:08]

On 21 December 2011 16:48, David Symonds <dsymonds@golang.org> wrote:
> On Wed, Dec 21, 2011 at 3:42 PM, Andrew Gerrand <adg@golang.org> wrote:
>
>> Nope. One we have Go 1 in App Engine it can be renamed to time.Duration.
>
> No you won't. time.Time will be supported, but datastore doesn't know
> anything about time durations.

Yeah, but IIRC the datastore can store named types when the concrete
type is something it understands.