Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1447)

Issue 5498074: code review 5498074: weekly.2011-12-22 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by adg
Modified:
8 years, 11 months ago
Reviewers:
CC:
dsymonds, r2, r, rsc, adg1, mikio, golang-dev
Visibility:
Public.

Description

weekly.2011-12-22

Patch Set 1 #

Patch Set 2 : diff -r 15d0e4a1597a https://code.google.com/p/go #

Patch Set 3 : diff -r 15d0e4a1597a https://code.google.com/p/go #

Total comments: 6

Patch Set 4 : diff -r 15d0e4a1597a https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r e029f0f2941f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -11 lines) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 3 4 10 chunks +117 lines, -10 lines 0 comments Download

Messages

Total messages: 12
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
8 years, 11 months ago (2011-12-22 23:34:53 UTC) #1
dsymonds
Isn't it 2011-12-22 by now?
8 years, 11 months ago (2011-12-22 23:36:48 UTC) #2
adg
Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 11 months ago (2011-12-22 23:38:51 UTC) #3
adg
Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 11 months ago (2011-12-22 23:39:31 UTC) #4
r2
can we hold off until gri's done with godoc? i think he's really close -rob
8 years, 11 months ago (2011-12-22 23:42:41 UTC) #5
adg
On 23 December 2011 10:42, Rob 'Commander' Pike <r@google.com> wrote: > can we hold off ...
8 years, 11 months ago (2011-12-22 23:45:27 UTC) #6
r
http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html#newcode29 doc/devel/weekly.html:29: "go" tool. Most users should be unaffected by the ...
8 years, 11 months ago (2011-12-22 23:54:18 UTC) #7
rsc
http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html#newcode28 doc/devel/weekly.html:28: There was a lot of churn in the tree ...
8 years, 11 months ago (2011-12-23 00:42:47 UTC) #8
adg1
http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html#newcode28 doc/devel/weekly.html:28: There was a lot of churn in the tree ...
8 years, 11 months ago (2011-12-23 01:21:35 UTC) #9
r
LGTM
8 years, 11 months ago (2011-12-23 01:26:37 UTC) #10
mikio
http://codereview.appspot.com/5498074/diff/5004/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5498074/diff/5004/doc/devel/weekly.html#newcode70 doc/devel/weekly.html:70: make sure use of pthread for gcc-4.5 and beyond ...
8 years, 11 months ago (2011-12-23 02:01:40 UTC) #11
adg
8 years, 11 months ago (2011-12-23 03:28:11 UTC) #12
*** Submitted as 4a8268927758 ***

weekly.2011-12-22

R=dsymonds, r, r, rsc, adg, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/5498074
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b