code review 5498074: weekly.2011-12-22

weekly.2011-12-22

[adg, 2011-12-22 23:34:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2011-12-22 23:36:48]

Isn't it 2011-12-22 by now?

[adg, 2011-12-22 23:38:51]

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-12-22 23:39:31]

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r2, 2011-12-22 23:42:41]

can we hold off until gri's done with godoc? i think he's really close

-rob

[adg, 2011-12-22 23:45:27]

On 23 December 2011 10:42, Rob 'Commander' Pike <r@google.com> wrote:
> can we hold off until gri's done with godoc? i think he's really close

Sure, just wanted to get the notes written up.

[r, 2011-12-22 23:54:18]

http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html#newcode29
doc/devel/weekly.html:29: "go" tool. Most users should be unaffected by the
changes.
that's just not fair.

you need to put the go tool changes front and center and you need to mention the
USE_GO_TOOL  flag. lots of people may have trouble

http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html#newcode79
doc/devel/weekly.html:79: * html: more parser improvements (thanks Andrew
Balholm).
there was actually a signature change in html/template, but i doubt anyone
noticed

[rsc, 2011-12-23 00:42:47]

http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html#newcode28
doc/devel/weekly.html:28: There was a lot of churn in the tree this week to make
it build with the new
This weekly adds a new command named 'go' for building and
testing go programs.  For Go 1, the go command will replace
the makefile-based approach that we have been using.
It is not yet ready for general use, but all.bash does use
it to build the tree.  If you have problems building the
weekly, you can 'export USE_GO_TOOL=false' before running
all.bash to fall back to the makefiles.

[adg1, 2011-12-23 01:21:35]

http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html#newcode28
doc/devel/weekly.html:28: There was a lot of churn in the tree this week to make
it build with the new
On 2011/12/23 00:42:47, rsc wrote:
> This weekly adds a new command named 'go' for building and
> testing go programs.  For Go 1, the go command will replace
> the makefile-based approach that we have been using.
> It is not yet ready for general use, but all.bash does use
> it to build the tree.  If you have problems building the
> weekly, you can 'export USE_GO_TOOL=false' before running
> all.bash to fall back to the makefiles.

Done.

http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html#newcode29
doc/devel/weekly.html:29: "go" tool. Most users should be unaffected by the
changes.
On 2011/12/22 23:54:19, r wrote:
> that's just not fair.
> 
> you need to put the go tool changes front and center and you need to mention
the
> USE_GO_TOOL  flag. lots of people may have trouble

Done.

http://codereview.appspot.com/5498074/diff/1003/doc/devel/weekly.html#newcode79
doc/devel/weekly.html:79: * html: more parser improvements (thanks Andrew
Balholm).
On 2011/12/22 23:54:19, r wrote:
> there was actually a signature change in html/template, but i doubt anyone
> noticed

You mean FuncMap? that was in the last weekly.

[r, 2011-12-23 01:26:37]

LGTM

[mikio, 2011-12-23 02:01:40]

http://codereview.appspot.com/5498074/diff/5004/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5498074/diff/5004/doc/devel/weekly.html#newcode70
doc/devel/weekly.html:70: make sure use of pthread for gcc-4.5 and beyond
(thanks Mikio Hara),
oops, I've submitted w/ typo.
cmd/gc is wrong, cmd/go is correct.

[adg, 2011-12-23 03:28:11]

*** Submitted as 4a8268927758 ***

weekly.2011-12-22

R=dsymonds, r, r, rsc, adg, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/5498074