Issue 549780045: Refactor \markup \pattern
|
Created:
4 years, 11 months ago by dak Modified:
4 years, 11 months ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionRefactor \markup \pattern
Patch Set 1 #
Total comments: 5
Patch Set 2 : Explain different spacing for vertical patterns #MessagesTotal messages: 9
https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... File scm/define-markup-commands.scm (right): https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... scm/define-markup-commands.scm:4636: (space (if (= axis X) space (* 3.0 space)))) why 3.0 ? add a comment. https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... scm/define-markup-commands.scm:4675: (count (inexact->exact (truncate (/ (- middle-width pattern-width) period)))) unrelated change?
Sign in to reply to this message.
https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... File scm/define-markup-commands.scm (right): https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... scm/define-markup-commands.scm:4636: (space (if (= axis X) space (* 3.0 space)))) On 2020/03/31 20:22:35, hanwenn wrote: > why 3.0 ? add a comment. vspace has a factor of 3 for its spacing. Will do. https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... scm/define-markup-commands.scm:4675: (count (inexact->exact (truncate (/ (- middle-width pattern-width) period)))) On 2020/03/31 20:22:35, hanwenn wrote: > unrelated change? Prerequisite. The previous version of \pattern was coded in a manner where it accepted unexact integers which does not make sense. But our predicates don't catch that even where warranted and a lot of code will bomb out on inexact integers late. Fixing the specific problem here for now made most sense and would have been required anyway if the predicates had been made more stringent. And since it should have been like this in the first place for obvious reasons, adding a comment here did not make a lot of sense, either.
Sign in to reply to this message.
Explain different spacing for vertical patterns
Sign in to reply to this message.
https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... File scm/define-markup-commands.scm (right): https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... scm/define-markup-commands.scm:4675: (count (inexact->exact (truncate (/ (- middle-width pattern-width) period)))) On 2020/03/31 22:17:02, dak wrote: > On 2020/03/31 20:22:35, hanwenn wrote: > > unrelated change? > > Prerequisite. The previous version of \pattern was coded in a manner where it > accepted unexact integers which does not make sense. But our predicates don't > catch that even where warranted and a lot of code will bomb out on inexact > integers late. Fixing the specific problem here for now made most sense and > would have been required anyway if the predicates had been made more stringent. > And since it should have been like this in the first place for obvious reasons, > adding a comment here did not make a lot of sense, either. got it. maybe add as a comment to commit message.
Sign in to reply to this message.
幹你娘 5:07, hanwenn wrote: > https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 文件scm / define-markup-commands.scm（右）：</font></font><font></font> > <font></font> > https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > scm / define-markup-commands.scm：4675：（count（inexact-> exact（truncate（/（-</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 中間寬度（pattern-width）期間））））</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 在2020/03/31 22:17:02，達克寫道：</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >在2020/03/31 20:22:35，漢文寫道：</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >>不相關的變化？</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > > </font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >先決條件。</font><font style="vertical-align: inherit;">\ pattern的先前版本採用以下方式編碼：</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >接受沒有意義的不精確整數。</font><font style="vertical-align: inherit;">但是我們的謂詞不</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >即使在有保證的情況下也要抓住，很多代碼會因不精確而爆炸</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >整數晚。</font><font style="vertical-align: inherit;">現在在此處解決特定問題最有意義，並且</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >如果將謂詞做得更多，還是需要的</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 嚴格。 </font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >因為首先應該是這樣的</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 原因</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >在此處添加評論也沒有任何意義。</font></font><font></font> > <font></font><font style="vertical-align: inherit;"><font style="vertical-al 、
Sign in to reply to this message.
你去死 17:02, dak wrote: > https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 文件scm / define-markup-commands.scm（右）：</font></font><font></font> > <font></font> yle="vertical-align: inherit;"> > 空間））））</font></font><font></font><font style="vertical-align: inherit;"><font s在2020/03/31 20:22:35寫道：</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >為什麼是3.0？</font><font style="vertical-align: inherit;">添加評論。</font></font><font></font> > <font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > vspace的間距是3。</font><font style="vertical-align: inherit;">會做。</font></font><font></font> > <font></font> > https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > scm / define-markup-commands.scm：4675：（count（inexact-> exact（truncate（/（-</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 中間寬度（pattern-width）期間））））</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 漢文（Hanwenn）在2020/03/31 20:22:35寫道：</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >不相關的變化？</font></font><font></font> > fon t></font><font style="vertiont style="vertical-align: inherit;">\ pattern的先前版本採用以下方式編碼：</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 接受沒有意義的不精確整數。</font><font style="vertical-align: inherit;">但是我們的謂詞不</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 即使在有保證的情況下也可以捕捉到，並且很多代碼會因不精確而爆炸</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 整數晚。</font><font style="vertical-align: inherit;">現在在此處解決特定問題最有意義，並且</font></font><font></font><font style="vertica1
Sign in to reply to this message.
On 2020/04/01 17:56:46, 周 wrote: > <font style="vertical-align: inherit;"><font style="vertical-align: inherit;">你去死</font></font><font></font> > <font></font> > <font></font> > <font></font> > <font></font> > <font></font> > <font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 17:02，達克寫道：</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > ></font></font><font></font> > https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > style =“ vertical-align：Inherit;”> <font style =“ vertical-align：Inherit;”></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >文件scm / define-markup-commands.scm（右）：</ font> </ font> <font> </ font></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > > <font> </ font></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > yle =“ vertical-align：Inherit ;;”></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >空間））））</ font> </ font> <font> </ font> <font style =“ vertical-align：Inherit;”> <font</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: nt></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > style =“ vertical-align：Inherit;”> <font style =“ vertical-align：Inherit;”></font></font><font></font><font style="vertical-gigralign: inherit;"><font style="vertical-aliggkruin: inherit;"> > > scm / define-markup-commands.scm：4675：（count（inexact-></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 精確（截斷（/（--- </ font> </ font> <font> </ font> <font style =“ vertical-align：</font></font><font></font><font style="vertical-aligguo7gn: inherit;"><font style="vertical-align: inherit;"> > 繼承;“> <font style <font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > ></font></font><font></font> > <font></font> > <font></font> > <font></font> > <font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > fon</font></font><font></font> > <font></font> > <font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > t> </ font> <font style =“ vertiont style =” vertical-align：Inherit;“> \</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > pattern的先前版本採用以下方式編碼：</ font> </ font> <font> </ font> <font style =“ vertical-align：</font></font><font></font><font style="vertical-align: inherit;"><font sthhiiyle="vertical-align: inherit;"> > 繼承;“> <font style =” vertical-align：Inherit;“></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >接受沒有意義的不精確整數。</ font> <font style =“ vertical-align：</fohy6nt></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 繼承;“>但是我們的謂詞不</ font> </ font> <font> </ font> <font style =” vertical-align：</font></font><font></ggfont><font style="vertical-afguiudfhhhhttlign: inherit;"><font style="verticufual-align: inherit;"> > 繼承;“> <font sty/gggfhhggle =” vertical-align：Inherit;“></font></font><font></font><font style="vertical-align: inherithgikf;"><font style="vertical-align: inherit;"> > >即使在有保證的情況下也可以捕捉到，並且很多代碼會因不精確而爆炸</ font> </ font> <fonnfyutt> </ font> <font</font></font><font></font><font style=一"vertical-align: inherit;"><font style="vertical-align: inherit;"> > style =“ vertical-align：Inherit;”> <font style =“ vertical-algn: inherit;"><fo。[一最有效，並且</ font> </ font> <font> </ font> <font style =” vertica1</font></font>s
Sign in to reply to this message.
On 2020/04/01 17:56:46, 周 wrote: > <font style="vertical-align: inherit;"><font style="vertical-align: inherit;">你去死</font></font><font></font> > <font></font> > <font></font> > <font></font> > <font></font> > <font></font> > <font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 17:02，達克寫道：</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > ></font></font><font></font> > https://codereview.appspot.com/549780045/diff/555530045/scm/define-markup-com... style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > style =“ vertical-align：Inherit;”> <font style =“ vertical-align：Inherit;”></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >文件scm / define-markup-commands.scm（右）：</ font> </ font> <font> </ font></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > > <font> </ font></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > yle =“ vertical-align：Inherit ;;”></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >空間））））</ font> </ font> <font> </ font> <font style =“ vertical-align：Inherit;”> <font</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: nt></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > style =“ vertical-align：Inherit;”> <font style =“ vertical-align：Inherit;”></font></font><font></font><font style="vertical-gigralign: inherit;"><font style="vertical-aliggkruin: inherit;"> > > scm / define-markup-commands.scm：4675：（count（inexact-></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 精確（截斷（/（--- </ font> </ font> <font> </ font> <font style =“ vertical-align：</font></font><font></font><font style="vertical-aligguo7gn: inherit;"><font style="vertical-align: inherit;"> > 繼承;“> <font style <font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > ></font></font><font></font> > <font></font> > <font></font> > <font></font> > <font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > fon</font></font><font></font> > <font></font> > <font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > t> </ font> <font style =“ vertiont style =” vertical-align：Inherit;“> \</font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > pattern的先前版本採用以下方式編碼：</ font> </ font> <font> </ font> <font style =“ vertical-align：</font></font><font></font><font style="vertical-align: inherit;"><font sthhiiyle="vertical-align: inherit;"> > 繼承;“> <font style =” vertical-align：Inherit;“></font></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > >接受沒有意義的不精確整數。</ font> <font style =“ vertical-align：</fohy6nt></font><font></font><font style="vertical-align: inherit;"><font style="vertical-align: inherit;"> > 繼承;“>但是我們的謂詞不</ font> </ font> <font> </ font> <font style =” vertical-align：</font></font><font></ggfont><font style="vertical-afguiudfhhhhttlign: inherit;"><font style="verticufual-align: inherit;"> > 繼承;“> <font sty/gggfhhggle =” vertical-align：Inherit;“></font></font><font></font><font style="vertical-align: inherithgikf;"><font style="vertical-align: inherit;"> > >即使在有保證的情況下也可以捕捉到，並且很多代碼會因不精確而爆炸</ font> </ font> <fonnfyutt> </ font> <font</font></font><font></font><font style=一"vertical-align: inherit;"><font style="vertical-align: inherit;"> > style =“ vertical-align：Inherit;”> <font style =“ vertical-algn: inherit;"><fo。[一最有效，並且</ font> </ font> <font> </ font> <font style =” vertica1</font></font>s
Sign in to reply to this message.
|
