Issue 5496047: code review 5496047: go/printer, gofmt: don't write too many newlines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5496047: code review 5496047: go/printer, gofmt: don't write too many newlines (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by gri

Modified:
13 years, 3 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

go/printer, gofmt: don't write too many newlines In some rare cases, gofmt would accept more than the maximum number of empty lines (1) between source code snippets. The actual change is in printer.go, lines 773-775; the rest is some minor restructuring. Applied gofmt -w src misc . Fixes issue 2387.

Patch Set 1 #

Patch Set 2 : diff -r 6cfb9f2415fa https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6cfb9f2415fa https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9ffee5b34ea0 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -54 lines)			Patch
M	src/cmd/cgo/godefs.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/bytes/buffer_test.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/pkg/go/printer/printer.go	View	1	13 chunks	+51 lines, -49 lines	0 comments	Download
M	src/pkg/go/printer/testdata/statements.golden	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-12-15 21:44:49 UTC) #1

gri

13 years, 3 months ago (2011-12-15 21:51:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=68962b02be7e ***

go/printer, gofmt: don't write too many newlines

In some rare cases, gofmt would accept more than the maximum
number of empty lines (1) between source code snippets.

The actual change is in printer.go, lines 773-775; the rest
is some minor restructuring.

Applied gofmt -w src misc .

Fixes issue 2387.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5496047

Expand All Messages | Collapse All Messages