Issue 5495044: code review 5495044: html: handle end tags in foreign objects.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5495044: code review 5495044: html: handle end tags in foreign objects. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by nigeltao

Modified:
13 years, 3 months ago

Reviewers:

CC:
andybalholm, golang-dev

Visibility:
Public.

Description

html: handle end tags in foreign objects. I'm not 100% sure I get all the corner cases right, for end tags, but I'll let the test suite smoke it out. Pass tests10.dat, test 1: <!DOCTYPE html><svg></svg><![CDATA[a]]> | <!DOCTYPE html> | <html> | <head> | <body> | <svg svg> |  Also pass tests through test 5: <!DOCTYPE html><body><table><svg></svg></table>

Patch Set 1 #

Patch Set 2 : diff -r 295ed44ba15b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 295ed44ba15b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 68962b02be7e https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -6 lines)			Patch
M	src/pkg/html/const.go	View	1	2 chunks	+11 lines, -1 line	0 comments	Download
M	src/pkg/html/parse.go	View	1	5 chunks	+16 lines, -5 lines	0 comments	Download
M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello andybalholm@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-12-15 07:09:18 UTC) #1

nigeltao

13 years, 3 months ago (2011-12-15 22:36:58 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ddcbb234be31 ***

html: handle end tags in foreign objects.

I'm not 100% sure I get all the corner cases right, for end tags, but
I'll let the test suite smoke it out.

Pass tests10.dat, test 1:
<!DOCTYPE html><svg></svg><![CDATA[a]]>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <svg svg>
|     <!-- [CDATA[a]] -->

Also pass tests through test 5:
<!DOCTYPE html><body><table><svg></svg></table>

R=andybalholm
CC=golang-dev
http://codereview.appspot.com/5495044

Expand All Messages | Collapse All Messages