code review 5494057: exp/ssh: rename (some) fields

exp/ssh: rename (some) fields

[cw, 2011-12-16 18:37:44]

RFC/Musing

(when reading over things I started renaming things and ended up here)

[agl1, 2011-12-16 20:42:12]

In the existing src/pkg code, 'FooId' greatly wins out over 'FooID'. It would
seem that swimming against the tide would be wrong.

[cw, 2011-12-16 20:45:49]

> In the existing src/pkg code, 'FooId' greatly wins out over 'FooID'. It
> would seem that swimming against the tide would be wrong.

does it?  for some reason i thought acronyms being UPPER was more
prevalent

[agl, 2011-12-16 20:49:28]

On Fri, Dec 16, 2011 at 3:45 PM, Chris Wedgwood <cw@f00f.org> wrote:
>> In the existing src/pkg code, 'FooId' greatly wins out over 'FooID'. It
>> would seem that swimming against the tide would be wrong.
>
> does it?  for some reason i thought acronyms being UPPER was more
> prevalent

go/src/pkg$ grep '[a-z]ID[^a-zA-Z]' -r .

vs

go/src/pkg$ grep '[a-z]Id[^a-zA-Z]' -r .

It seems that Id is the way to go. Possibility pertinent is that Id/ID
isn't an acronym, it's just a truncation of 'Identifier'. In the same
fashion, it's PeerCert, not PeerCERT.


Cheers

AGL

[cw, 2011-12-20 02:40:11]

Hello dave@cheney.net, agl@chromium.org, agl@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2011-12-20 08:32:01]

Looks pretty good too me, thanks for cleaning this up.

http://codereview.appspot.com/5494057/diff/1003/src/pkg/exp/ssh/client.go
File src/pkg/exp/ssh/client.go (right):

http://codereview.appspot.com/5494057/diff/1003/src/pkg/exp/ssh/client.go#new...
src/pkg/exp/ssh/client.go:342: // fixup peersID field
Now the comment is out of sync with c.peersId

http://codereview.appspot.com/5494057/diff/1003/src/pkg/exp/ssh/session.go
File src/pkg/exp/ssh/session.go (right):

http://codereview.appspot.com/5494057/diff/1003/src/pkg/exp/ssh/session.go#ne...
src/pkg/exp/ssh/session.go:76: stdinPipe, stdoutPipe, stderrPipe bool
I'd like to keep these as lower case, for no good reason.

[cw, 2012-01-16 07:49:44]

PTAL

I reverted the stdinPipe, stdoutPipe, stderrPipe changed as requested, though I
do feel it looks better with them.

[dave_cheney.net, 2012-01-16 08:07:08]

LGTM. Thanks for this.

[agl1, 2012-01-16 15:09:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=3fcc15997bbc ***

exp/ssh: rename (some) fields

R=dave, agl, agl
CC=golang-dev
http://codereview.appspot.com/5494057

Committer: Adam Langley <agl@golang.org>