Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1800)

Issue 5494045: code review 5494045: weekly.2011-12-14 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by adg
Modified:
9 years, 2 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

weekly.2011-12-14

Patch Set 1 #

Patch Set 2 : diff -r 533d76fb35b1 https://go.googlecode.com/hg #

Total comments: 19

Patch Set 3 : diff -r 533d76fb35b1 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 2d9ac660f013 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 3 1 chunk +105 lines, -0 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
9 years, 2 months ago (2011-12-15 04:34:10 UTC) #1
r
http://codereview.appspot.com/5494045/diff/2001/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5494045/diff/2001/doc/devel/weekly.html#newcode22 doc/devel/weekly.html:22: The rune type is now an alias for int32. ...
9 years, 2 months ago (2011-12-15 05:00:01 UTC) #2
adg
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 2 months ago (2011-12-15 05:14:42 UTC) #3
adg
http://codereview.appspot.com/5494045/diff/2001/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5494045/diff/2001/doc/devel/weekly.html#newcode22 doc/devel/weekly.html:22: The rune type is now an alias for int32. ...
9 years, 2 months ago (2011-12-15 05:14:56 UTC) #4
r
LGTM but mention rune constants http://codereview.appspot.com/5494045/diff/2002/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5494045/diff/2002/doc/devel/weekly.html#newcode27 doc/devel/weekly.html:27: The rune type is ...
9 years, 2 months ago (2011-12-15 05:50:00 UTC) #5
adg
9 years, 2 months ago (2011-12-15 05:56:20 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=82fdc445f2ff ***

weekly.2011-12-14

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5494045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b