code review 5493047: exp/ssh: simplify Stdin/out/errPipe methods

exp/ssh: simplify Stdin/out/errPipe methods

If a Pipe method is called, return the underlying
reader/writer from session.clientChan, bypassing the
io.Copy and io.Pipe harness.

StdoutPipe and StderrPipe now return an io.Reader not
an io.ReadCloser as SSH cannot signal the close of the
local reader to the remote process.

[dave_cheney.net, 2011-12-15 11:19:58]

Hello rsc@golang.org, agl@golang.org, gustav.paul@gmail.com, cw@f00f.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[agl1, 2011-12-15 15:48:44]

LGTM. Will leave a while to see if anyone else has comments.

http://codereview.appspot.com/5493047/diff/5001/src/pkg/exp/ssh/session.go
File src/pkg/exp/ssh/session.go (right):

http://codereview.appspot.com/5493047/diff/5001/src/pkg/exp/ssh/session.go#ne...
src/pkg/exp/ssh/session.go:76: stdinpipe, stdoutpipe, stderrpipe bool
stdinPipe and so on?

[cw, 2011-12-15 19:58:24]

LGTM (working here)

[agl1, 2011-12-15 21:50:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=9ffee5b34ea0 ***

exp/ssh: simplify Stdin/out/errPipe methods

If a Pipe method is called, return the underlying
reader/writer from session.clientChan, bypassing the
io.Copy and io.Pipe harness.

StdoutPipe and StderrPipe now return an io.Reader not
an io.ReadCloser as SSH cannot signal the close of the
local reader to the remote process.

R=rsc, agl, gustav.paul, cw
CC=golang-dev
http://codereview.appspot.com/5493047

Committer: Adam Langley <agl@golang.org>