Issue 54930043: Add python3 ibus-setup.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54930043: Add python3 ibus-setup. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by fujiwara

Modified:
10 years, 3 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Enable python3 ibus-setup. The default uses 'python' and if the path of python 3 is 'python3', ./configure --with-python=python3

Patch Set 1 #

Patch Set 2 : Forgot to add setup/Makefile.am #

Patch Set 3 : Updated with message #2. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -28 lines)			Patch
M	configure.ac	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
D	setup/enginecombobox.py	View	1 2	7 chunks	+17 lines, -8 lines	0 comments	Download
D	setup/enginetreeview.py	View	1 2	3 chunks	+7 lines, -6 lines	0 comments	Download
D	setup/keyboardshortcut.py	View	1 2	3 chunks	+5 lines, -5 lines	0 comments	Download
D	setup/main.py	View	1 2	9 chunks	+12 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fujiwara

Some formats are changed in python3. - print stderr uses file argument in python3. - ...

10 years, 3 months ago (2014-01-21 08:06:51 UTC) #1

Peng

On 2014/01/21 08:06:51, fujiwara wrote: > Some formats are changed in python3. > > - ...

10 years, 3 months ago (2014-01-22 21:31:33 UTC) #2

fujiwara

On 2014/01/22 21:31:33, Peng wrote: > On 2014/01/21 08:06:51, fujiwara wrote: > > Some formats ...

10 years, 3 months ago (2014-01-23 10:18:49 UTC) #3

Peng

10 years, 3 months ago (2014-01-23 12:23:50 UTC) #4

On 2014/01/23 10:18:49, fujiwara wrote:
> On 2014/01/22 21:31:33, Peng wrote:
> > On 2014/01/21 08:06:51, fujiwara wrote:
> > > Some formats are changed in python3.
> > > 
> > > - print stderr uses file argument in python3.
> > > - sort(function) is no longer supported in python3.
> > > 
> > > Since file argument is not supported in python2, if python2 cannot be used
> in
> > > the code.
> > 
> > Is it possible to use same code to support both python 2 and python 3.
> > 
> > As I know, in python 2, you may use something like 'import __future__' to
> enable
> > some python 3 features. And then you could modify current code to make it
run
> on
> > both versions.
> 
> Great. I imported __future__ and updated the patch.

Lgtm

Expand All Messages | Collapse All Messages