Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 5492063: code review 5492063: runtime: hg revert -r 6ec0a5c12d75 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by rsc
Modified:
14 years, 10 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

runtime: hg revert -r 6ec0a5c12d75 That was the last build that was close to working. I will try that change again next week. Make is being very subtle today. At the reverted-to CL, the ARM traceback appears to be broken. I'll look into that next week too.

Patch Set 1 #

Patch Set 2 : diff -r b7f404f924cc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b7f404f924cc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0d0dc291de62 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -236 lines) Patch
M src/Make.pkg View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/Makefile View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/make.bash View 1 1 chunk +1 line, -7 lines 0 comments Download
M src/pkg/runtime/Makefile View 1 2 10 chunks +57 lines, -26 lines 0 comments Download
R src/pkg/runtime/Makefile.auto View 1 1 chunk +0 lines, -101 lines 0 comments Download
M src/pkg/runtime/asm_386.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/defs1_linux.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs2_linux.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_arm_linux.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_darwin.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_freebsd.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_linux.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_netbsd.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_openbsd.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/defs_windows.go View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/goc2c.c View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/pkg/runtime/lock_futex.c View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/lock_sema.c View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/runtime/mkasmh.sh View 1 3 chunks +2 lines, -23 lines 0 comments Download
M src/pkg/runtime/mkgodefs.sh View 1 2 chunks +2 lines, -22 lines 0 comments Download
M src/pkg/runtime/mkversion.c View 1 1 chunk +1 line, -7 lines 0 comments Download
M src/pkg/runtime/rt0_windows_amd64.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/signal_darwin_amd64.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_darwin_386.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_darwin_amd64.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_freebsd_386.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_freebsd_amd64.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_linux_386.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_linux_amd64.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_linux_arm.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_netbsd_386.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_netbsd_amd64.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_openbsd_386.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_openbsd_amd64.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_plan9_386.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_windows_386.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_windows_amd64.s View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 10 months ago (2011-12-16 23:47:01 UTC) #1
r
LGTM
14 years, 10 months ago (2011-12-16 23:50:05 UTC) #2
rsc
14 years, 10 months ago (2011-12-16 23:50:42 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=2bbd12916333 ***

runtime: hg revert -r 6ec0a5c12d75

That was the last build that was close to working.
I will try that change again next week.
Make is being very subtle today.

At the reverted-to CL, the ARM traceback appears
to be broken.  I'll look into that next week too.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5492063
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b