Issue 5492058: code review 5492058: gob: isZero for struct values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5492058: code review 5492058: gob: isZero for struct values (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by r

Modified:
13 years, 3 months ago

Reviewers:
rsc

CC:
golang-dev, r2, gri

Visibility:
Public.

gob: isZero for struct values Fixes issue 2577.

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	src/pkg/encoding/gob/encode.go	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	src/pkg/encoding/gob/gobencdec_test.go	View		2 chunks	+28 lines, -0 lines	0 comments	Download

Total messages: 5

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-12-16 19:01:54 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=9836ab89b890 *** gob: isZero for struct values Fixes issue 2577. R=golang-dev, r, ...

13 years, 3 months ago (2011-12-16 19:34:02 UTC) #4

rsc

13 years, 3 months ago (2011-12-16 19:35:56 UTC) #5

I don't remember the details but it seems like you
could argue that array should be handled more like
struct and less like slice.

Russ