Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 5491058: code review 5491058: os/exec: fix -test.run argument for new 'go test' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by rsc
Modified:
13 years, 3 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

os/exec: fix -test.run argument for new 'go test' In 'go test' I deleted the leading package. prefix from all the test names, since it contained no actual information. Adjust the -test.run argument accordingly. This will still work with the current gotest too, since the argument is an unanchored pattern.

Patch Set 1 #

Patch Set 2 : diff -r 56842d9b23d2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 56842d9b23d2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 56842d9b23d2 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b3a51e474d9c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/os/exec/exec_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2011-12-15 23:09:57 UTC) #1
bradfitz
What's with all the FAILs in pkgs.out? On Thu, Dec 15, 2011 at 3:09 PM, ...
13 years, 3 months ago (2011-12-15 23:12:41 UTC) #2
rsc
On Thu, Dec 15, 2011 at 18:12, Brad Fitzpatrick <bradfitz@golang.org> wrote: > What's with all ...
13 years, 3 months ago (2011-12-15 23:16:15 UTC) #3
rsc
ptal
13 years, 3 months ago (2011-12-15 23:16:40 UTC) #4
bradfitz
LGTM On Thu, Dec 15, 2011 at 3:16 PM, Russ Cox <rsc@golang.org> wrote: > ptal ...
13 years, 3 months ago (2011-12-15 23:17:30 UTC) #5
rsc
13 years, 3 months ago (2011-12-15 23:21:41 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=d8cd324adb8f ***

os/exec: fix -test.run argument for new 'go test'

In 'go test' I deleted the leading package. prefix
from all the test names, since it contained no actual
information.  Adjust the -test.run argument accordingly.
This will still work with the current gotest too, since
the argument is an unanchored pattern.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5491058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b