Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 5491053: Remesh modifier (dual contouring) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by nicholasbishop
Modified:
10 years, 2 months ago
Reviewers:
sergey.vfx, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This patch adds a new remeshing modifier. The algorithm is based on the paper "Dual Contouring of Hermite Data", and the implementation was contributed to Blender by Dr. Tao Ju. The contributed code is in intern/dualcon, and was modified to compile under gcc and work on 64-bit systems. A small C wrapper was also added in order to interface it with Blender. Other than that, the rest of the patch is just standard modifier stuff. Documentation and examples on the Blender wiki: http://wiki.blender.org/index.php/User:Nicholasbishop/RemeshModifier

Patch Set 1 #

Patch Set 2 : Hmm, trying again, this time with the intern/dualcon directory included :) #

Total comments: 10

Patch Set 3 : Updated with fixes from first review #

Patch Set 4 : Replace eigen.h and eigen.cpp #

Patch Set 5 : Compilation fix and GPL headers #

Total comments: 2

Patch Set 6 : Remove $Id$ and clean up more static arrays #

Patch Set 7 : Updated with build fixes from Sergey #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9035 lines, -3 lines) Patch
intern/CMakeLists.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
intern/SConscript View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
intern/dualcon/CMakeLists.txt View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
intern/dualcon/SConscript View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
intern/dualcon/dualcon.h View 1 2 3 1 chunk +95 lines, -0 lines 0 comments Download
intern/dualcon/intern/GeoCommon.h View 1 2 3 4 1 chunk +69 lines, -0 lines 0 comments Download
intern/dualcon/intern/MemoryAllocator.h View 1 2 3 4 1 chunk +219 lines, -0 lines 0 comments Download
intern/dualcon/intern/ModelReader.h View 1 2 3 4 1 chunk +64 lines, -0 lines 0 comments Download
intern/dualcon/intern/Projections.h View 1 2 3 4 5 6 1 chunk +844 lines, -0 lines 0 comments Download
intern/dualcon/intern/Projections.cpp View 1 2 3 4 1 chunk +76 lines, -0 lines 0 comments Download
intern/dualcon/intern/Queue.h View 1 2 3 4 1 chunk +110 lines, -0 lines 0 comments Download
intern/dualcon/intern/cubes.h View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
intern/dualcon/intern/dualcon_c_api.cpp View 1 2 1 chunk +191 lines, -0 lines 0 comments Download
intern/dualcon/intern/manifold_table.h View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download
intern/dualcon/intern/manifold_table.cpp View 1 2 3 4 1 chunk +282 lines, -0 lines 0 comments Download
intern/dualcon/intern/marching_cubes_table.h View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
intern/dualcon/intern/marching_cubes_table.cpp View 1 2 3 4 1 chunk +554 lines, -0 lines 0 comments Download
intern/dualcon/intern/octree.h View 1 2 3 4 5 1 chunk +1596 lines, -0 lines 0 comments Download
intern/dualcon/intern/octree.cpp View 1 2 3 4 5 1 chunk +4311 lines, -0 lines 0 comments Download
intern/dualcon/intern/readme.txt View 1 1 chunk +112 lines, -0 lines 0 comments Download
release/scripts/startup/bl_ui/properties_data_modifier.py View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
source/blender/blenkernel/BKE_mesh.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
source/blender/makesdna/DNA_modifier_types.h View 1 2 3 4 2 chunks +36 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_modifier.c View 1 2 3 4 4 chunks +55 lines, -0 lines 0 comments Download
source/blender/modifiers/CMakeLists.txt View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/modifiers/MOD_modifiertypes.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
source/blender/modifiers/SConscript View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
source/blender/modifiers/intern/MOD_remesh.c View 1 2 1 chunk +214 lines, -0 lines 0 comments Download
source/blender/modifiers/intern/MOD_util.c View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
source/blenderplayer/bad_level_call_stubs/stubs.c View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
source/creator/CMakeLists.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13
nicholasbishop
10 years, 5 months ago (2011-12-15 18:25:01 UTC) #1
nicholasbishop
Hmm, trying again, this time with the intern/dualcon directory included :)
10 years, 5 months ago (2011-12-15 18:27:46 UTC) #2
sergey.vfx
Hi, Made basic review (almost general design and code, not logic itself). There are some ...
10 years, 5 months ago (2011-12-16 14:58:03 UTC) #3
nicholasbishop
Updated with fixes from first review
10 years, 5 months ago (2011-12-18 00:12:25 UTC) #4
nicholasbishop
Thanks for reviewing :) Uploaded a new patch with some of the comments addressed. Also ...
10 years, 5 months ago (2011-12-18 00:25:05 UTC) #5
nicholasbishop
Replace eigen.h and eigen.cpp
10 years, 5 months ago (2011-12-19 08:14:51 UTC) #6
nicholasbishop
On 2011/12/19 08:14:51, nicholasbishop wrote: > Replace eigen.h and eigen.cpp Uploaded new patch that uses ...
10 years, 5 months ago (2011-12-19 08:16:24 UTC) #7
nicholasbishop
Compilation fix and GPL headers
10 years, 5 months ago (2011-12-19 16:04:30 UTC) #8
sergey.vfx
Hi, Just two minor tihngs noted incomments. And one thing i'm not sure about atm: ...
10 years, 5 months ago (2011-12-20 15:00:02 UTC) #9
nicholasbishop
Remove $Id$ and clean up more static arrays
10 years, 5 months ago (2011-12-21 19:36:23 UTC) #10
nicholasbishop
> http://codereview.appspot.com/5491053/diff/19/intern/dualcon/intern/octree.h#newcode101 > intern/dualcon/intern/octree.h:101: const int edgevmap[12][2] = > {{0,4},{1,5},{2,6},{3,7},{0,2},{1,3},{4,6},{5,7},{0,1},{2,3},{4,5},{6,7}}; > Still onfuses a bit ...
10 years, 5 months ago (2011-12-21 19:39:29 UTC) #11
sergey.vfx
Looks good to me.
10 years, 5 months ago (2011-12-21 20:14:53 UTC) #12
nicholasbishop
10 years, 5 months ago (2011-12-21 21:18:09 UTC) #13
Updated with build fixes from Sergey
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b