Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 5491048: code review 5491048: go: help messages for 'go test' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by rsc
Modified:
13 years, 3 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

go: help messages for 'go test' The plan is to make 'go test' replace gotest entirely, so it cannot refer to gotest's godoc. Instead, copy gotest's documentation in as three different help messages: 'go help test', 'go help testflag', and 'go help testfunc'.

Patch Set 1 #

Patch Set 2 : diff -r 533d76fb35b1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 533d76fb35b1 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 533d76fb35b1 https://go.googlecode.com/hg/ #

Total comments: 8

Patch Set 5 : diff -r 56290665c4e3 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r bb1b29810d65 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -4 lines) Patch
M src/cmd/go/main.go View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/go/test.go View 1 2 3 4 2 chunks +137 lines, -4 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2011-12-15 03:46:28 UTC) #1
r
http://codereview.appspot.com/5491048/diff/2003/src/cmd/go/test.go File src/cmd/go/test.go (right): http://codereview.appspot.com/5491048/diff/2003/src/cmd/go/test.go#newcode12 src/cmd/go/test.go:12: 'Go test' automates testing of the packages named by ...
13 years, 3 months ago (2011-12-15 04:24:11 UTC) #2
rsc
PTAL All comments done.
13 years, 3 months ago (2011-12-15 18:41:11 UTC) #3
r
LGTM
13 years, 3 months ago (2011-12-15 18:50:09 UTC) #4
rsc
13 years, 3 months ago (2011-12-15 18:54:21 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=56842d9b23d2 ***

go: help messages for 'go test'

The plan is to make 'go test' replace gotest entirely, so it
cannot refer to gotest's godoc.  Instead, copy gotest's
documentation in as three different help messages:
'go help test', 'go help testflag', and 'go help testfunc'.

R=r
CC=golang-dev
http://codereview.appspot.com/5491048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b