Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(4)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Unified Diff: src/pkg/runtime/defs_darwin.go
Issue
5490053
:
code review 5490053: runtime: make more build-friendly (Closed)
Patch Set: diff -r 046739c8299b https://go.googlecode.com/hg/
Created 13 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
src/pkg/runtime/Makefile
src/pkg/runtime/arch_386.h
src/pkg/runtime/arch_amd64.h
src/pkg/runtime/arch_arm.h
src/pkg/runtime/asm_386.s
src/pkg/runtime/asm_amd64.s
src/pkg/runtime/asm_arm.s
src/pkg/runtime/atomic_386.c
src/pkg/runtime/atomic_amd64.c
src/pkg/runtime/atomic_arm.c
src/pkg/runtime/callback_windows_386.c
src/pkg/runtime/callback_windows_amd64.c
src/pkg/runtime/cgocall.c
src/pkg/runtime/closure_386.c
src/pkg/runtime/closure_amd64.c
src/pkg/runtime/closure_arm.c
src/pkg/runtime/cpuprof.c
src/pkg/runtime/defs1_linux.go
src/pkg/runtime/defs2_linux.go
src/pkg/runtime/defs_arm_linux.go
src/pkg/runtime/defs_darwin.go
src/pkg/runtime/defs_darwin_386.h
src/pkg/runtime/defs_darwin_amd64.h
src/pkg/runtime/defs_freebsd.go
src/pkg/runtime/defs_freebsd_386.h
src/pkg/runtime/defs_freebsd_amd64.h
src/pkg/runtime/defs_linux.go
src/pkg/runtime/defs_linux_386.h
src/pkg/runtime/defs_linux_amd64.h
src/pkg/runtime/defs_linux_arm.h
src/pkg/runtime/defs_netbsd.go
src/pkg/runtime/defs_netbsd_386.h
src/pkg/runtime/defs_netbsd_amd64.h
src/pkg/runtime/defs_openbsd.go
src/pkg/runtime/defs_openbsd_386.h
src/pkg/runtime/defs_openbsd_amd64.h
src/pkg/runtime/defs_plan9_386.h
src/pkg/runtime/defs_windows.go
src/pkg/runtime/defs_windows_386.h
src/pkg/runtime/defs_windows_amd64.h
src/pkg/runtime/iface.c
src/pkg/runtime/malloc.goc
src/pkg/runtime/mcache.c
src/pkg/runtime/mcentral.c
src/pkg/runtime/mem_darwin.c
src/pkg/runtime/mem_freebsd.c
src/pkg/runtime/mem_linux.c
src/pkg/runtime/mem_netbsd.c
src/pkg/runtime/mem_openbsd.c
src/pkg/runtime/mem_plan9.c
src/pkg/runtime/mem_windows.c
src/pkg/runtime/memmove_386.s
src/pkg/runtime/memmove_amd64.s
src/pkg/runtime/memmove_arm.s
src/pkg/runtime/memset_arm.s
src/pkg/runtime/mfinal.c
src/pkg/runtime/mfixalloc.c
src/pkg/runtime/mgc0.c
src/pkg/runtime/mheap.c
src/pkg/runtime/mprof.goc
src/pkg/runtime/msize.c
src/pkg/runtime/os_darwin.h
src/pkg/runtime/os_freebsd.h
src/pkg/runtime/os_linux.h
src/pkg/runtime/os_netbsd.h
src/pkg/runtime/os_openbsd.h
src/pkg/runtime/os_plan9.h
src/pkg/runtime/os_windows.h
src/pkg/runtime/proc.c
src/pkg/runtime/rt0_darwin_386.s
src/pkg/runtime/rt0_darwin_amd64.s
src/pkg/runtime/rt0_freebsd_386.s
src/pkg/runtime/rt0_freebsd_amd64.s
src/pkg/runtime/rt0_linux_386.s
src/pkg/runtime/rt0_linux_amd64.s
src/pkg/runtime/rt0_linux_arm.s
src/pkg/runtime/rt0_netbsd_386.s
src/pkg/runtime/rt0_netbsd_amd64.s
src/pkg/runtime/rt0_openbsd_386.s
src/pkg/runtime/rt0_openbsd_amd64.s
src/pkg/runtime/rt0_plan9_386.s
src/pkg/runtime/rt0_windows_386.s
src/pkg/runtime/rt0_windows_amd64.s
src/pkg/runtime/runtime.h
src/pkg/runtime/sema.goc
src/pkg/runtime/signal_darwin_386.c
src/pkg/runtime/signal_darwin_amd64.c
src/pkg/runtime/signal_freebsd_386.c
src/pkg/runtime/signal_freebsd_amd64.c
src/pkg/runtime/signal_linux_386.c
src/pkg/runtime/signal_linux_amd64.c
src/pkg/runtime/signal_linux_arm.c
src/pkg/runtime/signal_netbsd_386.c
src/pkg/runtime/signal_netbsd_amd64.c
src/pkg/runtime/signal_openbsd_386.c
src/pkg/runtime/signal_openbsd_amd64.c
src/pkg/runtime/signal_plan9_386.c
src/pkg/runtime/signal_windows_386.c
src/pkg/runtime/signal_windows_amd64.c
src/pkg/runtime/signals_darwin.h
src/pkg/runtime/signals_freebsd.h
src/pkg/runtime/signals_linux.h
src/pkg/runtime/signals_netbsd.h
src/pkg/runtime/signals_openbsd.h
src/pkg/runtime/signals_plan9.h
src/pkg/runtime/signals_windows.h
src/pkg/runtime/sigqueue.goc
src/pkg/runtime/slice.c
src/pkg/runtime/softfloat_arm.c
src/pkg/runtime/stack.h
src/pkg/runtime/string.goc
src/pkg/runtime/symtab.c
src/pkg/runtime/sys_darwin_386.s
src/pkg/runtime/sys_darwin_amd64.s
src/pkg/runtime/sys_freebsd_386.s
src/pkg/runtime/sys_freebsd_amd64.s
src/pkg/runtime/sys_linux_386.s
src/pkg/runtime/sys_linux_amd64.s
src/pkg/runtime/sys_linux_arm.s
src/pkg/runtime/sys_netbsd_386.s
src/pkg/runtime/sys_netbsd_amd64.s
src/pkg/runtime/sys_openbsd_386.s
src/pkg/runtime/sys_openbsd_amd64.s
src/pkg/runtime/sys_plan9_386.s
src/pkg/runtime/sys_windows_386.s
src/pkg/runtime/sys_windows_amd64.s
src/pkg/runtime/syscall_windows.goc
src/pkg/runtime/thread_darwin.c
src/pkg/runtime/thread_freebsd.c
src/pkg/runtime/thread_linux.c
src/pkg/runtime/thread_netbsd.c
src/pkg/runtime/thread_openbsd.c
src/pkg/runtime/thread_plan9.c
src/pkg/runtime/thread_windows.c
src/pkg/runtime/time.goc
src/pkg/runtime/traceback_amd64.c
src/pkg/runtime/traceback_arm.c
src/pkg/runtime/vlop_386.s
src/pkg/runtime/vlop_arm.s
src/pkg/runtime/vlrt_386.c
src/pkg/runtime/vlrt_arm.c
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« src/pkg/runtime/defs_arm_linux.go
('k') |
src/pkg/runtime/defs_darwin_386.h »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: src/pkg/runtime/defs_darwin.go
===================================================================
rename from src/pkg/runtime/darwin/defs.go
rename to src/pkg/runtime/defs_darwin.go
« no previous file with comments
|
« src/pkg/runtime/defs_arm_linux.go
('k') |
src/pkg/runtime/defs_darwin_386.h »
('j') |
no next file with comments »
Issue 5490053: code review 5490053: runtime: make more build-friendly (Closed)
Created 13 years, 3 months ago by rsc
Modified 13 years, 3 months ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b