code review 5490047: more tags for go/build

more tags for go/build

[rsc, 2011-12-15 17:34:42]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-12-15 17:40:56]

LGTM

But I think terminal builds on more than just linux.  That can be done
later, though.


On Thu, Dec 15, 2011 at 9:34 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> more tags for go/build
>
> Please review this at
http://codereview.appspot.com/**5490047/<http://codereview.appspot.com/5490047/>
>
> Affected files:
>  M src/cmd/godoc/appinit.go
>  M src/pkg/exp/terminal/terminal.**go
>  M src/pkg/exp/terminal/terminal_**test.go
>  M src/pkg/exp/terminal/util.go
>  M src/pkg/exp/winfsnotify/**winfsnotify.go
>  M src/pkg/exp/winfsnotify/**winfsnotify_test.go
>  M src/pkg/exp/wingui/Makefile
>  M src/pkg/exp/wingui/gui.go
>  M src/pkg/exp/wingui/winapi.go
>  M src/pkg/exp/wingui/zwinapi.go
>
>
> Index: src/cmd/godoc/appinit.go
> ==============================**==============================**=======
> --- a/src/cmd/godoc/appinit.go
> +++ b/src/cmd/godoc/appinit.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build ignore
> +
>  package main
>
>  // This file replaces main.go when running godoc under app-engine.
> Index: src/pkg/exp/terminal/terminal.**go
> ==============================**==============================**=======
> --- a/src/pkg/exp/terminal/**terminal.go
> +++ b/src/pkg/exp/terminal/**terminal.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build linux
> +
>  package terminal
>
>  import "io"
> Index: src/pkg/exp/terminal/terminal_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/terminal/**terminal_test.go
> +++ b/src/pkg/exp/terminal/**terminal_test.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build linux
> +
>  package terminal
>
>  import (
> Index: src/pkg/exp/terminal/util.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/terminal/util.go
> +++ b/src/pkg/exp/terminal/util.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build linux
> +
>  // Package terminal provides support functions for dealing with
> terminals, as
>  // commonly found on UNIX systems.
>  //
> Index: src/pkg/exp/winfsnotify/**winfsnotify.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/winfsnotify/**winfsnotify.go
> +++ b/src/pkg/exp/winfsnotify/**winfsnotify.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build windows
> +
>  // Package winfsnotify allows the user to receive
>  // file system event notifications on Windows.
>  package winfsnotify
> Index: src/pkg/exp/winfsnotify/**winfsnotify_test.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/winfsnotify/**winfsnotify_test.go
> +++ b/src/pkg/exp/winfsnotify/**winfsnotify_test.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build windows
> +
>  package winfsnotify
>
>  import (
> Index: src/pkg/exp/wingui/Makefile
> ==============================**==============================**=======
> --- a/src/pkg/exp/wingui/Makefile
> +++ b/src/pkg/exp/wingui/Makefile
> @@ -18,6 +18,7 @@
>  include ../../../Make.cmd
>
>  zwinapi.go: winapi.go
> -      
$(GOROOT)/src/pkg/syscall/mksy**scall_windows.pl<http://mksyscall_windows.pl>$<
\
> +       (echo '// +build windows'; \
> +      
$(GOROOT)/src/pkg/syscall/mksy**scall_windows.pl<http://mksyscall_windows.pl>$<)
\
>                | gofmt \
>                > $@
> Index: src/pkg/exp/wingui/gui.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/wingui/gui.go
> +++ b/src/pkg/exp/wingui/gui.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build windows
> +
>  package main
>
>  import (
> Index: src/pkg/exp/wingui/winapi.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/wingui/winapi.go
> +++ b/src/pkg/exp/wingui/winapi.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build windows
> +
>  package main
>
>  import (
> Index: src/pkg/exp/wingui/zwinapi.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/wingui/zwinapi.**go
> +++ b/src/pkg/exp/wingui/zwinapi.**go
> @@ -1,3 +1,4 @@
> +// +build windows
>  // mksyscall_windows.pl winapi.go
>  // MACHINE GENERATED BY THE COMMAND ABOVE; DO NOT EDIT
>
>
>
>

[rsc, 2011-12-15 18:31:29]

On Thu, Dec 15, 2011 at 12:40, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> But I think terminal builds on more than just linux.

It might but pkg/Makefile only builds it on linux.
I think the BSD-based systems use termio not termios.

[rsc, 2011-12-15 18:36:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=56290665c4e3 ***

more tags for go/build

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5490047

[iant2, 2011-12-15 20:57:14]

Russ Cox <rsc@golang.org> writes:

> On Thu, Dec 15, 2011 at 12:40, Brad Fitzpatrick <bradfitz@golang.org> wrote:
>> But I think terminal builds on more than just linux.
>
> It might but pkg/Makefile only builds it on linux.
> I think the BSD-based systems use termio not termios.

That can't be right.  termios has been in POSIX.1 for decades.

However, it is certainly possible that BSD-based systems implement
termios in libc rather than at the kernel layer.

Ian