Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(140)

Issue 5489100: code review 5489100: go/build: add new +build tags 'cgo' and 'nocgo' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by rsc
Modified:
8 years, 11 months ago
Reviewers:
CC:
golang-dev, ality, mikio
Visibility:
Public.

Description

go/build: add new +build tags 'cgo' and 'nocgo' This lets us mark net's cgo_stub.go as only to be built when cgo is disabled.

Patch Set 1 #

Patch Set 2 : diff -r 4c20d297d01d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4c20d297d01d https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r ffa7e53815de https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ffa7e53815de https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 40e366e721a9 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 40e366e721a9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -18 lines) Patch
M src/cmd/go/main.go View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M src/pkg/crypto/tls/root_stub.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/debug/gosym/pclinetest.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/debug/gosym/pclinetest.s View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/go/build/build_test.go View 1 2 3 4 5 3 chunks +12 lines, -1 line 0 comments Download
M src/pkg/go/build/dir.go View 1 2 3 4 5 5 chunks +44 lines, -10 lines 0 comments Download
M src/pkg/net/cgo_stub.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
8 years, 11 months ago (2011-12-21 12:42:35 UTC) #1
ality
Thanks for doing this. https://codereview.appspot.com/5489100/diff/8/src/pkg/go/build/dir.go File src/pkg/go/build/dir.go (right): https://codereview.appspot.com/5489100/diff/8/src/pkg/go/build/dir.go#newcode98 src/pkg/go/build/dir.go:98: if DefaultContext.GOOS == "openbsd" || ...
8 years, 11 months ago (2011-12-21 13:19:23 UTC) #2
rsc
PTAL Reorganized to list what does work instead of what doesn't.
8 years, 11 months ago (2011-12-21 13:23:39 UTC) #3
ality
LGTM
8 years, 11 months ago (2011-12-21 13:28:42 UTC) #4
mikio
It's very close on openbsd. ok flag ok fmt FAIL go/build --- FAIL: TestBuild (0.15 ...
8 years, 11 months ago (2011-12-21 13:32:00 UTC) #5
rsc
PTAL Thanks for the report.
8 years, 11 months ago (2011-12-21 13:40:36 UTC) #6
mikio
LGTM OpenBSD is back.
8 years, 11 months ago (2011-12-21 13:47:53 UTC) #7
rsc
8 years, 11 months ago (2011-12-21 13:51:22 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=a6f76d1d70f4 ***

go/build: add new +build tags 'cgo' and 'nocgo'

This lets us mark net's cgo_stub.go as only to be
built when cgo is disabled.

R=golang-dev, ality, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/5489100
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b