Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 5489065: code review 5489065: various: use $GCFLAGS and $GCIMPORTS like Make does

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by mpimenov
Modified:
10 years, 3 months ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

various: use $GCFLAGS and $GCIMPORTS like Make does

Patch Set 1 #

Patch Set 2 : diff -r f95e094d062e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f95e094d062e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M doc/codelab/wiki/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M misc/cgo/gmp/Makefile View 1 1 chunk +2 lines, -2 lines 0 comments Download
M misc/cgo/life/Makefile View 1 2 chunks +2 lines, -2 lines 0 comments Download
M misc/cgo/stdio/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M misc/cgo/testso/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M misc/swig/callback/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M misc/swig/stdio/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/goyacc/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/gob/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/norm/Makefile View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/go/doc/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/unicode/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M test/bench/garbage/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
mpimenov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2011-12-16 16:22:17 UTC) #1
rsc
Work on Makefiles is not worthwhile at this point. They are going to be deleted ...
13 years, 3 months ago (2011-12-16 16:24:01 UTC) #2
mpimenov
> Is this causing problems for you? Yes, but it's not very urgent, so it's ...
13 years, 3 months ago (2011-12-16 16:30:07 UTC) #3
rsc
LGTM
13 years, 3 months ago (2011-12-16 16:30:48 UTC) #4
rsc
13 years, 3 months ago (2011-12-16 16:31:45 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=e03f5fc4f701 ***

various: use $GCFLAGS and $GCIMPORTS like Make does

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5489065

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b