Issue 5489060: code review 5489060: govet: add checking for printf verbs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5489060: code review 5489060: govet: add checking for printf verbs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by r

Modified:
13 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

govet: add checking for printf verbs Also fix the errors it catches. Fixes issue 1654.

Patch Set 1 #

Patch Set 2 : diff -r 7c8a0711cc3a https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -8 lines)			Patch
M	src/cmd/govet/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/govet/print.go	View	7 chunks	+68 lines, -3 lines	0 comments	Download
M	src/pkg/encoding/xml/marshal_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/http/readrequest_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/textproto/reader_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/os_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-12-15 22:40:58 UTC) #1

13 years, 3 months ago (2011-12-15 23:17:57 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e0550761a4e0 ***

govet: add checking for printf verbs
Also fix the errors it catches.

Fixes issue 1654.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5489060

Expand All Messages | Collapse All Messages