Issue 5489058: code review 5489058: govet: divide the program into one file per vetting suite

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5489058: code review 5489058: govet: divide the program into one file per vetting suite (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by r

Modified:
13 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

govet: divide the program into one file per vetting suite Just a rearrangement except for a couple of new functions and names so govet.go can have all the generic walk routines.

Patch Set 1 #

Patch Set 2 : diff -r 6cfb9f2415fa https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -1710 lines)			Patch
M	src/cmd/govet/Makefile	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/govet/govet.go	View	4 chunks	+38 lines, -379 lines	0 comments	Download
M	src/cmd/govet/method.go	View	3 chunks	+3 lines, -415 lines	0 comments	Download
M	src/cmd/govet/print.go	View	2 chunks	+3 lines, -374 lines	0 comments	Download
M	src/cmd/govet/structtag.go	View	2 chunks	+3 lines, -542 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2011-12-15 21:28:11 UTC) #1

13 years, 3 months ago (2011-12-15 21:44:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c733d5362851 ***

govet: divide the program into one file per vetting suite
Just a rearrangement except for a couple of new functions
and names so govet.go can have all the generic walk routines.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5489058

Expand All Messages | Collapse All Messages