http://codereview.appspot.com/5488082/diff/2001/samples/adsense/get_account_tree.py File samples/adsense/get_account_tree.py (right): http://codereview.appspot.com/5488082/diff/2001/samples/adsense/get_account_tree.py#newcode36 samples/adsense/get_account_tree.py:36: account_id = 'INSERT_ACCOUNT_ID_HERE' use gflags and make this a ...
12 years, 8 months ago
(2012-01-09 14:30:55 UTC)
#2
http://codereview.appspot.com/5488082/diff/4003/samples/adsense/generate_report.py File samples/adsense/generate_report.py (right): http://codereview.appspot.com/5488082/diff/4003/samples/adsense/generate_report.py#newcode33 samples/adsense/generate_report.py:33: gflags.DEFINE_string('ad_client_id', None, Flag definitions go at the global scope.
12 years, 8 months ago
(2012-01-12 14:08:03 UTC)
#4
Thanks, suggestion applied across all files with the issue. http://codereview.appspot.com/5488082/diff/4003/samples/adsense/generate_report.py File samples/adsense/generate_report.py (right): http://codereview.appspot.com/5488082/diff/4003/samples/adsense/generate_report.py#newcode33 samples/adsense/generate_report.py:33: ...
12 years, 8 months ago
(2012-01-12 15:53:07 UTC)
#5
http://codereview.appspot.com/5488082/diff/5006/samples/adsense/get_account_tree.py File samples/adsense/get_account_tree.py (right): http://codereview.appspot.com/5488082/diff/5006/samples/adsense/get_account_tree.py#newcode18 samples/adsense/get_account_tree.py:18: This includes the full tree of sub-accounts. Blank line ...
12 years, 8 months ago
(2012-01-18 13:43:44 UTC)
#6
http://codereview.appspot.com/5488082/diff/5006/samples/adsense/get_account_tree.py File samples/adsense/get_account_tree.py (right): http://codereview.appspot.com/5488082/diff/5006/samples/adsense/get_account_tree.py#newcode18 samples/adsense/get_account_tree.py:18: This includes the full tree of sub-accounts. On 2012/01/18 ...
12 years, 8 months ago
(2012-01-20 13:57:18 UTC)
#7
http://codereview.appspot.com/5488082/diff/5006/samples/adsense/get_account_tree.py File samples/adsense/get_account_tree.py (right): http://codereview.appspot.com/5488082/diff/5006/samples/adsense/get_account_tree.py#newcode18 samples/adsense/get_account_tree.py:18: This includes the full tree of sub-accounts. Does this ...
12 years, 7 months ago
(2012-01-31 17:21:23 UTC)
#8
Sorry, I thought you meant remove, rather than add. Done for all files. --- On ...
12 years, 7 months ago
(2012-02-01 11:38:06 UTC)
#9
Sorry, I thought you meant remove, rather than add. Done for all files.
---
On 2012/01/31 17:21:23, jcgregorio_google wrote:
>
http://codereview.appspot.com/5488082/diff/5006/samples/adsense/get_account_t...
> File samples/adsense/get_account_tree.py (right):
>
>
http://codereview.appspot.com/5488082/diff/5006/samples/adsense/get_account_t...
> samples/adsense/get_account_tree.py:18: This includes the full tree of
> sub-accounts.
> Does this patch need to be refreshed? I don't see a blank line between lines
17
> and 18.
>
> On 2012/01/20 13:57:18, sgomes wrote:
> > On 2012/01/18 13:43:49, jcgregorio_google wrote:
> > > Blank line between the single line description and the rest of the
> > description.
> >
> > Done.
On 2012/02/07 18:58:50, jcgregorio_google wrote: > LGTM Committed in http://code.google.com/p/google-api-python-client/source/detail?r=75895416612f356be5b6a14acf41c3409076f195
12 years, 7 months ago
(2012-02-07 19:32:18 UTC)
#11
Issue 5488082: AdSense Management API v1.1 code samples
(Closed)
Created 12 years, 9 months ago by sgomes
Modified 12 years, 4 months ago
Reviewers: jcgregorio_google
Base URL:
Comments: 19