code review 5487077: gc: inlining, allow empty bodies, fix _ arguments.

gc: inlining, allow empty bodies, fix _ arguments.

[lvd, 2011-12-14 14:52:33]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-12-14 15:15:24]

Maybe it is time to create test/inline.go with code that trips up
the inliner?  It is easy to imagine someone reverting the change
to cmp.go without knowing what it tests.

[lvd, 2011-12-14 15:24:49]

a fine plan!  i'll wrap up my pending CLs and get to that

On Wed, Dec 14, 2011 at 16:15, Russ Cox <rsc@golang.org> wrote:
> Maybe it is time to create test/inline.go with code that trips up
> the inliner?  It is easy to imagine someone reverting the change
> to cmp.go without knowing what it tests.

[rsc, 2011-12-14 15:30:09]

On Wed, Dec 14, 2011 at 10:24, Luuk van Dijk <lvd@google.com> wrote:
> a fine plan!  i'll wrap up my pending CLs and get to that

for this CL it just needs to be

test/inline.go

// $G $D/$F.go || echo BUG: inline
package main

func used(b bool) { _ = b }

[lvd, 2011-12-14 15:36:31]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-12-15 16:03:36]

LGTM

[lvd, 2011-12-15 16:51:03]

*** Submitted as http://code.google.com/p/go/source/detail?r=d905490a3a9e ***

gc: inlining, allow empty bodies, fix _ arguments.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5487077