src/pkg/math/cbrt.go - Issue 5484076: code review 5484076: pkg/math: undo manual inlining of IsInf and IsNaN

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/math/cbrt.go

Issue 5484076: code review 5484076: pkg/math: undo manual inlining of IsInf and IsNaN (Closed)

Patch Set: diff -r 7c0d2f963500 https://go.googlecode.com/hg/ Created 13 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/math/cbrt.go

===================================================================

--- a/src/pkg/math/cbrt.go

+++ b/src/pkg/math/cbrt.go

@@ -33,11 +33,9 @@

C3 = 6.46502159e-02

C4 = 1.412333954e-01

)

- // TODO(rsc): Remove manual inlining of IsNaN, IsInf

- // when compiler does it for us

// special cases

switch {

- case x == 0 || x != x || x < -MaxFloat64 || x > MaxFloat64: // x == 0 || IsNaN(x) || IsInf(x, 0):

+ case x == 0 || IsNaN(x) || IsInf(x, 0):

return x

}

sign := false

« no previous file with comments | « src/pkg/math/atanh.go ('k') | src/pkg/math/dim.go » ('j') | no next file with comments »