Issue 5483088: code review 5483088: sql: add Rows.Columns

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5483088: code review 5483088: sql: add Rows.Columns (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bradfitz

Modified:
13 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

sql: add Rows.Columns Also, fix package name in error messages. Fixes issue 2453

Patch Set 2 : diff -r d8bb178f0f19 https://go.googlecode.com/hg #

Patch Set 3 : diff -r d8bb178f0f19 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 021414aecce6 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -18 lines)			Patch
	M	src/pkg/exp/sql/sql.go	View	1 2 3	9 chunks	+27 lines, -14 lines	0 comments	Download
	M	src/pkg/exp/sql/sql_test.go	View	1	2 chunks	+21 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 3 months ago (2011-12-14 23:23:38 UTC) #1

rsc

http://codereview.appspot.com/5483088/diff/4001/src/pkg/exp/sql/sql.go File src/pkg/exp/sql/sql.go (right): http://codereview.appspot.com/5483088/diff/4001/src/pkg/exp/sql/sql.go#newcode740 src/pkg/exp/sql/sql.go:740: // Columns returns the column names. Say when it ...

13 years, 3 months ago (2011-12-15 16:38:00 UTC) #2

bradfitz

13 years, 3 months ago (2011-12-15 18:14:58 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e22a8db91330 ***

sql: add Rows.Columns

Also, fix package name in error messages.

Fixes issue 2453

R=rsc
CC=golang-dev
http://codereview.appspot.com/5483088

Expand All Messages | Collapse All Messages