Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 5477056: code review 5477056: doc/go1: the simpler package changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by r
Modified:
13 years, 6 months ago
Reviewers:
CC:
golang-dev, albert.strasheim, dsymonds, r2, adg
Visibility:
Public.

Description

doc/go1: the simpler package changes

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 0b6a29e8fd41 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0b6a29e8fd41 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 78eb7505299e https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r 78eb7505299e https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 9991bd04f20a https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 264fb4d09991 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -56 lines) Patch
M doc/go1.html View 1 2 3 4 5 6 chunks +148 lines, -28 lines 0 comments Download
M doc/go1.tmpl View 1 2 3 4 5 6 chunks +136 lines, -28 lines 0 comments Download
M doc/progs/go1.go View 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 6 months ago (2011-12-09 23:30:27 UTC) #1
albert.strasheim
http://codereview.appspot.com/5477056/diff/1/doc/go1.html File doc/go1.html (right): http://codereview.appspot.com/5477056/diff/1/doc/go1.html#newcode637 doc/go1.html:637: <a href="/pkg/syscall"><code>strconv</code></a> /pkg/strconv?
13 years, 6 months ago (2011-12-10 05:47:21 UTC) #2
r
Hello golang-dev@googlegroups.com, fullung@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 6 months ago (2011-12-10 06:01:33 UTC) #3
dsymonds
Just a random drive-by thought. http://codereview.appspot.com/5477056/diff/1/doc/go1.tmpl File doc/go1.tmpl (right): http://codereview.appspot.com/5477056/diff/1/doc/go1.tmpl#newcode515 doc/go1.tmpl:515: <a href="/pkg/syscall"><code>syscall</code></a> Can you ...
13 years, 6 months ago (2011-12-10 06:02:35 UTC) #4
r
Hello golang-dev@googlegroups.com, fullung@gmail.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 6 months ago (2011-12-10 06:41:02 UTC) #5
r2
On Dec 9, 2011, at 10:02 PM, dsymonds@golang.org wrote: > Can you make all the ...
13 years, 6 months ago (2011-12-10 06:41:18 UTC) #6
r
Hello golang-dev@googlegroups.com, fullung@gmail.com, dsymonds@golang.org, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 6 months ago (2011-12-12 04:11:24 UTC) #7
r
Hello golang-dev@googlegroups.com, fullung@gmail.com, dsymonds@golang.org, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 6 months ago (2011-12-12 04:48:46 UTC) #8
adg
LGTM http://codereview.appspot.com/5477056/diff/2002/doc/go1.html File doc/go1.html (right): http://codereview.appspot.com/5477056/diff/2002/doc/go1.html#newcode731 doc/go1.html:731: standard Go 1 release distributions, although they will ...
13 years, 6 months ago (2011-12-12 05:14:11 UTC) #9
r
Hello golang-dev@googlegroups.com, fullung@gmail.com, dsymonds@golang.org, r@google.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 6 months ago (2011-12-12 17:58:05 UTC) #10
r
13 years, 6 months ago (2011-12-12 20:27:01 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=0b2bc58dc830 ***

doc/go1: the simpler package changes

R=golang-dev, fullung, dsymonds, r, adg
CC=golang-dev
http://codereview.appspot.com/5477056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b