Issue 547700043: sources: fix handling of non-existent include files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 547700043: sources: fix handling of non-existent include files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 2 months ago by hanwenn

Modified:
5 years, 1 month ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

sources: fix handling of non-existent include files A recent refactoring calles String::String on a null pointer for non-existent files.

Patch Set 1 #

Patch Set 2 : link commit #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	lily/sources.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hanwenn

i have this now: commit d8aaab93d8c640dc6343c3dfdcf177778e69ccc6 (HEAD -> not-found) Author: Han-Wen Nienhuys <hanwen@lilypond.org> Date: Fri ...

5 years, 2 months ago (2020-02-28 18:43:35 UTC) #2

hanwenn

5 years, 1 month ago (2020-03-15 15:34:08 UTC) #3

On 2020/02/28 18:43:35, hanwenn wrote:
commit 1bba00b04f1379972c9dd24717067aa10643229c
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Fri Feb 28 19:03:23 2020 +0100

    sources: fix handling of non-existent include files

Expand All Messages | Collapse All Messages