Report better stack traces on more platforms

Fixes issues 1877 and 1876. Progress on issue 1751

Major changes to debug.js to try to report stacks accurately on more platforms.
Factored common logic from compileExpr and compileExprLater into prepareExpr.
Changed useHTMLLogger to better emulate console stack-display.
Changed explicit.html to show that stack display on each platform.

[MarkM, 2014-01-21 01:21:40]

Major changes to debug.js to try to report stacks accurately on more platforms.
Factored common logic from compileExpr and compileExprLater into prepareExpr.
Changed useHTMLLogger to better emulate console stack-display.
Changed explicit.html to show that stack display on each platform.

[kpreid2, 2014-01-21 18:26:19]

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/compil...
File src/com/google/caja/ses/compileExprLater.js (right):

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/compil...
src/com/google/caja/ses/compileExprLater.js:18: * outcome of attempting to
compile the argument expression.
This comment doesn't explain what compileExprLater is useful for. Is it just a
relic of designing for ES5/3 compatibility?

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/compil...
src/com/google/caja/ses/compileExprLater.js:94: JSON.stringify(prep.options) +
')));' + prep.suffixSrc;
It would be nice if it was made more obvious that the generated code was
well-formed and escaping-correct, but I have no specific ideas on how to do so.

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/debug.js
File src/com/google/caja/ses/debug.js (right):

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/debug....
src/com/google/caja/ses/debug.js:212: framePatterns.some(function(framePattern)
{
Not using return value is odd, maybe point out you're using this for a breakable
array iterator?

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/debug....
src/com/google/caja/ses/debug.js:221: span = [[+sub[2],+sub[3]]];
space after comma, no strong reason not to

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/startS...
File src/com/google/caja/ses/startSES.js (right):

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/startS...
src/com/google/caja/ses/startSES.js:847: // TODO(erights): validate
Clarify this comment for maintainers who aren't you.

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/useHTM...
File src/com/google/caja/ses/useHTMLLogger.js (right):

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/useHTM...
src/com/google/caja/ses/useHTMLLogger.js:148: appendText(link, urlText);
This can be link.textContent = urlText.

[kpreid2, 2014-02-03 23:06:00]

ping?

By the way, other comment: I would prefer that the summary line say what is
changed, rather than referring to issue numbers, so that it can be understood at
a glance without looking up issues.

[MarkM, 2014-02-22 17:53:36]

Major changes to debug.js to try to report stacks accurately on more platforms.
Factored common logic from compileExpr and compileExprLater into prepareExpr.
Changed useHTMLLogger to better emulate console stack-display.
Changed explicit.html to show that stack display on each platform.

[MarkM, 2014-02-22 21:36:44]

Major changes to debug.js to try to report stacks accurately on more platforms.
Factored common logic from compileExpr and compileExprLater into prepareExpr.
Changed useHTMLLogger to better emulate console stack-display.
Changed explicit.html to show that stack display on each platform.

[MarkM, 2014-02-22 21:41:19]

Major changes to debug.js to try to report stacks accurately on more platforms.
Factored common logic from compileExpr and compileExprLater into prepareExpr.
Changed useHTMLLogger to better emulate console stack-display.
Changed explicit.html to show that stack display on each platform.

[MarkM, 2014-02-22 21:50:37]

Major changes to debug.js to try to report stacks accurately on more platforms.
Factored common logic from compileExpr and compileExprLater into prepareExpr.
Changed useHTMLLogger to better emulate console stack-display.
Changed explicit.html to show that stack display on each platform.

[MarkM, 2014-02-22 21:51:39]

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/compil...
File src/com/google/caja/ses/compileExprLater.js (right):

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/compil...
src/com/google/caja/ses/compileExprLater.js:18: * outcome of attempting to
compile the argument expression.
On 2014/01/21 18:26:20, kpreid2 wrote:
> This comment doesn't explain what compileExprLater is useful for. Is it just a
> relic of designing for ES5/3 compatibility?

Done.

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/compil...
src/com/google/caja/ses/compileExprLater.js:94: JSON.stringify(prep.options) +
')));' + prep.suffixSrc;
On 2014/01/21 18:26:20, kpreid2 wrote:
> It would be nice if it was made more obvious that the generated code was
> well-formed and escaping-correct, but I have no specific ideas on how to do
so.

Done, in the sense that "more obvious" does not imply "obvious" ;).

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/debug.js
File src/com/google/caja/ses/debug.js (right):

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/debug....
src/com/google/caja/ses/debug.js:212: framePatterns.some(function(framePattern)
{
On 2014/01/21 18:26:20, kpreid2 wrote:
> Not using return value is odd, maybe point out you're using this for a
breakable
> array iterator?

Done.

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/debug....
src/com/google/caja/ses/debug.js:221: span = [[+sub[2],+sub[3]]];
On 2014/01/21 18:26:20, kpreid2 wrote:
> space after comma, no strong reason not to

Done.

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/startS...
File src/com/google/caja/ses/startSES.js (right):

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/startS...
src/com/google/caja/ses/startSES.js:847: // TODO(erights): validate
On 2014/01/21 18:26:20, kpreid2 wrote:
> Clarify this comment for maintainers who aren't you.

Done. Turns out there was a security issue as well -- the possibility that the
sourceURL might be multiline, and thereby escape the line comment. Fixed that as
well. PTAL.

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/useHTM...
File src/com/google/caja/ses/useHTMLLogger.js (right):

https://codereview.appspot.com/54760043/diff/2/src/com/google/caja/ses/useHTM...
src/com/google/caja/ses/useHTMLLogger.js:148: appendText(link, urlText);
On 2014/01/21 18:26:20, kpreid2 wrote:
> This can be link.textContent = urlText.

Done. Thanks.

[kpreid2, 2014-02-24 20:16:58]

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/co...
File src/com/google/caja/ses/compileExprLater.js (right):

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/co...
src/com/google/caja/ses/compileExprLater.js:106: '["' + prep.freeNames.join('",
"') + '"], ' +
If prep.freeNames is [] then this will be [""] — and the empty string is not an
identifier. This looks harmless since it goes into a scope object only, but
perhaps note that hazard.

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/ma...
File src/com/google/caja/ses/makeSimpleAMDLoader.js (right):

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/ma...
src/com/google/caja/ses/makeSimpleAMDLoader.js:128: '(function(){' + src +
'})()',
hazard if src ends with a line comment
end with ()), not )()

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/st...
File src/com/google/caja/ses/startSES.js (right):

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/st...
src/com/google/caja/ses/startSES.js:755: var hasLineTerminator =
(/[\u000A\u000D\u2028\u2029]/);
unnecessary parentheses

[kpreid2, 2014-02-24 20:19:08]

Please change the title so that it summarizes the changes without knowledge of
issue numbers.

[MarkM, 2014-02-25 02:05:54]

Major changes to debug.js to try to report stacks accurately on more platforms.
Factored common logic from compileExpr and compileExprLater into prepareExpr.
Changed useHTMLLogger to better emulate console stack-display.
Changed explicit.html to show that stack display on each platform.

[MarkM, 2014-02-25 02:07:10]

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/co...
File src/com/google/caja/ses/compileExprLater.js (right):

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/co...
src/com/google/caja/ses/compileExprLater.js:106: '["' + prep.freeNames.join('",
"') + '"], ' +
On 2014/02/24 20:16:59, kpreid2 wrote:
> If prep.freeNames is [] then this will be [""] — and the empty string is not
an
> identifier. This looks harmless since it goes into a scope object only, but
> perhaps note that hazard.

Done. I decided to fix it rather than note the hazard.

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/ma...
File src/com/google/caja/ses/makeSimpleAMDLoader.js (right):

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/ma...
src/com/google/caja/ses/makeSimpleAMDLoader.js:128: '(function(){' + src +
'})()',
On 2014/02/24 20:16:59, kpreid2 wrote:
> hazard if src ends with a line comment
> end with ()), not )()

Done.

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/st...
File src/com/google/caja/ses/startSES.js (right):

https://codereview.appspot.com/54760043/diff/80001/src/com/google/caja/ses/st...
src/com/google/caja/ses/startSES.js:755: var hasLineTerminator =
(/[\u000A\u000D\u2028\u2029]/);
On 2014/02/24 20:16:59, kpreid2 wrote:
> unnecessary parentheses

Done. For consistency, I also removed similar unnecessary parens in debug.js.

[kpreid2, 2014-02-25 20:52:20]

LGTM

[MarkM, 2014-02-28 01:48:10]

Major changes to debug.js to try to report stacks accurately on more platforms.
Factored common logic from compileExpr and compileExprLater into prepareExpr.
Changed useHTMLLogger to better emulate console stack-display.
Changed explicit.html to show that stack display on each platform.

[MarkM, 2014-02-28 01:52:28]

Fixed a bug that was caught by the pre-submit testing.