Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 547540043: GUILE 2: Increase initial heap (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by hanwenn
Modified:
4 years, 2 months ago
Reviewers:
Dan Eble, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

GUILE 2: Increase initial heap This reduces the GC overhead for initialization from 0.3s to 0.12s. Total time goes from 1.7 to 1.2s, because LilyPond starts out with a larger heap after initialization.

Patch Set 1 #

Patch Set 2 : overwrite #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M lily/main.cc View 1 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 5
hanwenn
overwrite
4 years, 3 months ago (2020-01-29 08:53:54 UTC) #1
lemzwerg
LGTM https://codereview.appspot.com/547540043/diff/561380043/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/547540043/diff/561380043/lily/main.cc#newcode772 lily/main.cc:772: sane_putenv("GC_INITIAL_HEAP_SIZE", "40M", false); Do you think it makes ...
4 years, 3 months ago (2020-01-29 10:24:12 UTC) #2
Dan Eble
On 2020/01/29 10:24:12, lemzwerg wrote: > > Is there ever a reason for the user ...
4 years, 3 months ago (2020-01-29 11:55:40 UTC) #3
hanwenn
On 2020/01/29 10:24:12, lemzwerg wrote: > LGTM > > https://codereview.appspot.com/547540043/diff/561380043/lily/main.cc > File lily/main.cc (right): > ...
4 years, 3 months ago (2020-01-30 10:03:08 UTC) #4
hanwenn
4 years, 3 months ago (2020-01-30 10:04:30 UTC) #5
For deployments (say, our builds that always run on the same dedicated machine),
it makes sense to set this to a max size.

Servers at Google usually set the equivalent parameter for Java upfront as well,
because they get a fixed allocation of RAM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b