Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4849)

Issue 547470049: Doc: Corrected doc string for ly:dimension?

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by davidsg
Modified:
4 years, 3 months ago
Reviewers:
dak, thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Corrected doc string for ly:dimension? ly:dimension? is a predicate - it does not return a number.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lily/general-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
davidsg
It isn't clear to me how a dimension is different from a normal number, but ...
4 years, 3 months ago (2020-01-25 16:12:45 UTC) #1
thomasmorley651
I don't see any difference to checking for a number either. Thus "distinguish" feels strange. ...
4 years, 3 months ago (2020-01-26 10:45:11 UTC) #2
dak
4 years, 3 months ago (2020-01-26 11:49:32 UTC) #3
On 2020/01/26 10:45:11, thomasmorley651 wrote:
> I don't see any difference to checking for a number either. Thus "distinguish"
> feels strange.

There was a time when music function predicates determined syntactic decisions
based on what function they pointed to rather than what they evaluated to.  So
people were confused why their user-defined functions, say, number-or-string? ,
did not admit either numbers or strings syntactically.

ly:dimension? never made it to special status in the parser.  In olden times
that would mean that when using it as a music function argument, the respective
number could not be entered as a plain number but would always have to be
preceded with # .  This kind of predicate aliasing serves almost no point any
more (markup? and markup-list? in markups are still treated in that manner,
though).

> Ofcourse it's a predicate, thus
> LGTM
> 
> Thanks! You can't be motivated to go through the other doc-strings listed in
IR
> 4. Scheme functions ?
> :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b