Issue 547470044: Remove dead code throughout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 547470044: Remove dead code throughout (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 1 month ago by hanwenn

Modified:
6 years ago

Reviewers:
Dan Eble, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Patch Set 2 : description #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -89 lines)			Patch
M	lily/dispatcher.cc	View		3 chunks	+0 lines, -12 lines	0 comments	Download
M	lily/freetype.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	lily/grob-array.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	lily/include/smobs.hh	View	1	3 chunks	+6 lines, -7 lines	0 comments	Download
M	lily/smobs.cc	View		1 chunk	+2 lines, -35 lines	0 comments	Download
M	lily/stencil-integral.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	lily/ttf.cc	View		1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Dan Eble

https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh File lily/include/smobs.hh (left): https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh#oldcode316 lily/include/smobs.hh:316: SCM protection_cons_; Changing the size of a structure is ...

6 years, 1 month ago (2020-01-24 18:21:41 UTC) #2

hanwenn

6 years, 1 month ago (2020-01-24 18:50:23 UTC) #4

https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh
File lily/include/smobs.hh (left):

https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh...
lily/include/smobs.hh:316: SCM protection_cons_;
On 2020/01/24 18:21:40, Dan Eble wrote:
> Changing the size of a structure is not the first thing that comes to mind
when
> someone says "dead-code removal."  I'm happy to see this change, but it could
be
> summarized a little better.

Done.

https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh
File lily/include/smobs.hh (right):

https://codereview.appspot.com/547470044/diff/575540047/lily/include/smobs.hh...
lily/include/smobs.hh:319: Smob () { };
On 2020/01/24 18:21:40, Dan Eble wrote:
> Try this:
> 
>     Smob () = default;

Done.

Expand All Messages | Collapse All Messages