Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1921)

Issue 5472046: code review 5472046: gc: fix export of '\'' and '\\' constants (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by rsc
Modified:
10 years, 1 month ago
Reviewers:
dsymonds
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: fix export of '\'' and '\\' constants Fixes Windows build.

Patch Set 1 #

Patch Set 2 : diff -r 27f4b31f5c3c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 27f4b31f5c3c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/fmt.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 1 month ago (2011-12-09 03:43:29 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=f898ee415aef *** gc: fix export of '\'' and '\\' constants Fixes Windows ...
10 years, 1 month ago (2011-12-09 03:43:34 UTC) #2
dsymonds
On Fri, Dec 9, 2011 at 2:43 PM, <rsc@golang.org> wrote: > Description: > gc: fix ...
10 years, 1 month ago (2011-12-09 03:47:03 UTC) #3
rsc
On Thu, Dec 8, 2011 at 22:47, David Symonds <dsymonds@golang.org> wrote: > Hopefully it fixes ...
10 years, 1 month ago (2011-12-09 03:48:57 UTC) #4
dsymonds
On Fri, Dec 9, 2011 at 2:48 PM, Russ Cox <rsc@golang.org> wrote: > On Thu, ...
10 years, 1 month ago (2011-12-09 03:50:06 UTC) #5
rsc
10 years, 1 month ago (2011-12-09 03:52:35 UTC) #6
On Thu, Dec 8, 2011 at 22:50, David Symonds <dsymonds@golang.org> wrote:
>> Honestly, those guys look like they are running half new code
>> and half old code.  I've seen this a few times in the last year
>> or so and I wonder if the builder program is subtly broken.
>
> That's quite disturbing.

It could be Mercurial that is subtly broken.
I don't know.  Notice that linux/amd64 and freebsd/amd64
both have one ok and one fail here:

27f4b31f5c3c	spec: fix typo in example comment
c0f7c53dcfce	update tree for new default type rule

Those two can't get different results unless something
somewhere is broken.  windows was at least consistent
and had a believable error.

Russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b