Issue 54690051: state: add MongoSession method

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54690051: state: add MongoSession method

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by rog

Modified:
10 years, 2 months ago

Reviewers:
dimitern, natefinch, mp+205013

Visibility:
Public.

Description

state: add MongoSession method The replica set worker needs it to maintain the replica set. https://code.launchpad.net/~rogpeppe/juju-core/495-state-mongosession/+merge/205013 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : state: add MongoSession method #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/state.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	state/state_test.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dimitern

LGTM https://codereview.appspot.com/54690051/diff/1/state/state.go File state/state.go (right): https://codereview.appspot.com/54690051/diff/1/state/state.go#newcode119 state/state.go:119: func (st *State) MongoSession() *mgo.Session { doc comment, ...

10 years, 2 months ago (2014-02-05 17:38:43 UTC) #3

rog

10 years, 2 months ago (2014-02-05 17:47:25 UTC) #4

Please take a look.

https://codereview.appspot.com/54690051/diff/1/state/state.go
File state/state.go (right):

https://codereview.appspot.com/54690051/diff/1/state/state.go#newcode119
state/state.go:119: func (st *State) MongoSession() *mgo.Session {
On 2014/02/05 17:38:43, dimitern wrote:
> doc comment, incl. why do we expose this?

Done.

https://codereview.appspot.com/54690051/diff/1/state/state_test.go
File state/state_test.go (right):

https://codereview.appspot.com/54690051/diff/1/state/state_test.go#newcode64
state/state_test.go:64: c.Assert(s.State.MongoSession(), gc.Not(gc.IsNil))
On 2014/02/05 17:38:43, dimitern wrote:
> How about some checking on the session object (i.e. c.Assert(session.Ping(),
> IsNil))?

Done.

Expand All Messages | Collapse All Messages