Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(977)

Issue 5461043: [4.7][google] Adding a new option "-fstack-protector-strong".

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by shenhan
Modified:
2 years, 2 months ago
Reviewers:
jakub, pinskia, richard.guenther, xur, davidxl, Diego Novillo
CC:
gcc-patches_gcc.gnu.org, davidxi_google.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Updated per Andrew's and Richard's #

Patch Set 3 : Removed debugging prints #

Patch Set 4 : Modified per Jakub's #

Patch Set 5 : Per Jakub's & Andrew's #

Patch Set 6 : Updated #

Patch Set 7 : Synced with newest trunk #

Total comments: 5

Patch Set 8 : Modified per Rong's and David's comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -8 lines) Patch
M gcc/cfgexpand.c View 1 2 3 4 5 6 7 3 chunks +53 lines, -5 lines 0 comments Download
M gcc/common.opt View 1 2 3 4 5 6 7 1 chunk +5 lines, -1 line 0 comments Download
gcc/doc/invoke.texi View 1 2 3 4 5 6 7 2 chunks +8 lines, -2 lines 2 comments Download
A gcc/testsuite/g++.dg/fstack-protector-strong.C View 1 2 3 4 6 1 chunk +35 lines, -0 lines 0 comments Download
A gcc/testsuite/gcc.dg/fstack-protector-strong.c View 1 2 3 4 6 1 chunk +135 lines, -0 lines 0 comments Download

Messages

Total messages: 19
shenhan
Hi, this patch provides a new stack protection option - "fstack-protector-strong". Background - some times ...
2 years, 4 months ago #1
pinskia_gmail.com
On Wed, Dec 7, 2011 at 5:07 PM, Han Shen <shenhan@google.com> wrote: > + /* ...
2 years, 4 months ago #2
richard.guenther_gmail.com
On Thu, Dec 8, 2011 at 2:19 AM, Andrew Pinski <pinskia@gmail.com> wrote: > On Wed, ...
2 years, 4 months ago #3
Diego Novillo
On Wed, Dec 7, 2011 at 20:07, Han Shen <shenhan@google.com> wrote: > Status - implemented ...
2 years, 4 months ago #4
shenhan
Hi, Andrew and Richard, check via referenced vars is much easier, thanks! Updated patches attached ...
2 years, 4 months ago #5
jakub_redhat.com
On Thu, Dec 08, 2011 at 11:05:42AM -0800, Han Shen(沈涵) wrote: > --- a/gcc/cfgexpand.c > ...
2 years, 4 months ago #6
shenhan
Hi, Jakub, thanks! Patches modified according to gnu coding standards. -Han Patches (also on http://codereview.appspot.com/5461043) ...
2 years, 4 months ago #7
jakub_redhat.com
On Thu, Dec 08, 2011 at 02:02:23PM -0800, Han Shen(沈涵) wrote: > Hi, Jakub, thanks! ...
2 years, 4 months ago #8
pinskia_gmail.com
On Thu, Dec 8, 2011 at 2:02 PM, Han Shen(沈涵) <shenhan@google.com> wrote: > + FOR_EACH_REFERENCED_VAR(cfun, ...
2 years, 4 months ago #9
pinskia_gmail.com
On Thu, Dec 8, 2011 at 2:02 PM, Han Shen(沈涵) <shenhan@google.com> wrote: > +/* Address ...
2 years, 4 months ago #10
shenhan
Hi, Jakub, thanks! Fixed! Hi, Andrew, it's good suggestion. Done. Also modified foo10. A small ...
2 years, 4 months ago #11
shenhan
Hi, further comments? Or ok for submit? And as suggested by Diego, I'd like to ...
2 years, 4 months ago #12
shenhan
Hi, all, it's been a long time, I've slightly modified my code - TREE_ADDRESSABLE is ...
2 years, 3 months ago #13
shenhan
Another gentle ping? -Han On Mon, Jan 9, 2012 at 2:18 PM, Han Shen(沈涵) <shenhan@google.com> ...
2 years, 2 months ago #14
xur
OK for google branches. http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c File gcc/cfgexpand.c (right): http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1597 gcc/cfgexpand.c:1597: contain an array or are ...
2 years, 2 months ago #15
davidxl
Also need to update doc/invoke.texi file for the new option. http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c File gcc/cfgexpand.c (right): http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1531 ...
2 years, 2 months ago #16
shenhan
Hi, David and Rong, thanks a lot! Modified code uploaded as patch 8 and is ...
2 years, 2 months ago #17
davidxl
ok for google branches with the above changes. Please continue to seek upstream approval. David ...
2 years, 2 months ago #18
shenhan
2 years, 2 months ago #19
Hi, ping?

Could someone take a look at this patch, it has already been reviewed
several rounds. I'm to submit it to gcc trunk.

Thanks,
-Han

On Wed, Jan 25, 2012 at 9:41 PM, <davidxl@google.com> wrote:
>
> ok for google branches with the above changes. Please continue to seek
> upstream approval.
>
> David
>
>
> http://codereview.appspot.com/5461043/diff/19001/gcc/doc/invoke.texi
> File gcc/doc/invoke.texi (right):
>
>
http://codereview.appspot.com/5461043/diff/19001/gcc/doc/invoke.texi#newcode403
> gcc/doc/invoke.texi:403: +-fstack-protector-strong -fstack-protector-all
> -fstrict-aliasing @gol
> Switch the order of -fstack-protector-all and -fstack-proctor-strong (in
> alphabetic order)
>
>
http://codereview.appspot.com/5461043/diff/19001/gcc/doc/invoke.texi#newcode8446
> gcc/doc/invoke.texi:8446: +@item -fstack-protector-strong
> Move this item after -fstack-protector-all
>
> http://codereview.appspot.com/5461043/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1274:9b9295c7fd64