Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(269)

Issue 545630044: Remove OMF support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by hanwenn
Modified:
4 years ago
Reviewers:
Dan Eble, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove OMF support OMF (Open Source Metadata Framework) was an XML metadata format used to describe installed documentation for the Scrollkeeper documentation catalog. I believe this is unused in today's Linux system's (the only OMF file on my Fedora 31 install are LilyPond's.)

Patch Set 1 #

Total comments: 4

Patch Set 2 : hahnjo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -234 lines) Patch
M Documentation/GNUmakefile View 3 chunks +3 lines, -4 lines 0 comments Download
M Documentation/contributor/build-notes.itexi View 1 chunk +0 lines, -1 line 0 comments Download
M GNUmakefile.in View 2 chunks +0 lines, -2 lines 0 comments Download
M config.make.in View 2 chunks +0 lines, -5 lines 0 comments Download
M make/ly-rules.make View 1 2 chunks +1 line, -17 lines 0 comments Download
M make/ly-vars.make View 1 chunk +0 lines, -2 lines 0 comments Download
M scm/documentation-generate.scm View 1 chunk +0 lines, -9 lines 0 comments Download
D scripts/build/texi2omf.py View 1 chunk +0 lines, -157 lines 0 comments Download
D stepmake/stepmake/omf-rules.make View 1 chunk +0 lines, -2 lines 0 comments Download
D stepmake/stepmake/omf-targets.make View 1 chunk +0 lines, -16 lines 0 comments Download
D stepmake/stepmake/omf-vars.make View 1 chunk +0 lines, -5 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 1 3 chunks +2 lines, -10 lines 0 comments Download
M stepmake/stepmake/texinfo-vars.make View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6
hahnjo
https://codereview.appspot.com/545630044/diff/579320044/make/ly-rules.make File make/ly-rules.make (right): https://codereview.appspot.com/545630044/diff/579320044/make/ly-rules.make#newcode64 make/ly-rules.make:64: $(call ly_progress,Making,$@,< texi) You should delete these lines completely. ...
4 years, 1 month ago (2020-02-25 09:05:17 UTC) #1
hanwenn
hahnjo
4 years, 1 month ago (2020-02-26 21:08:56 UTC) #2
hanwenn
https://codereview.appspot.com/545630044/diff/579320044/make/ly-rules.make File make/ly-rules.make (right): https://codereview.appspot.com/545630044/diff/579320044/make/ly-rules.make#newcode64 make/ly-rules.make:64: $(call ly_progress,Making,$@,< texi) On 2020/02/25 09:05:17, hahnjo wrote: > ...
4 years, 1 month ago (2020-02-26 21:09:29 UTC) #3
hahnjo
LGTM
4 years, 1 month ago (2020-02-27 15:22:32 UTC) #4
Dan Eble
I'm glad to see cruft removed from makefiles.
4 years, 1 month ago (2020-02-28 00:33:21 UTC) #5
hanwenn
4 years ago (2020-03-06 20:10:51 UTC) #6
commit ba29c98fd4f91c7cbbf8a836c899622499156009
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Tue Feb 25 09:50:50 2020 +0100

    Remove OMF support
    
    OMF (Open Source Metadata Framework) was an XML metadata format used
    to describe installed documentation for the Scrollkeeper documentation
    catalog. I believe this is unused in today's Linux system's (the only
    OMF file on my Fedora 31 install are LilyPond's.)
    
    https://sourceforge.net/p/testlilyissues/issues/5791
    http://codereview.appspot.com/545630044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b