Issue 54560044: Add a very useful hint about relation ordering.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54560044: Add a very useful hint about relation ordering.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by benji

Modified:
10 years, 3 months ago

Reviewers:
mp+202373, rick.harding, benji-york

Visibility:
Public.

Description

Add a very useful hint about relation ordering. https://code.launchpad.net/~benji/charmworld/1263120-allow-self-referential-relations-in-bundles/+merge/202373 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a very useful hint about relation ordering. #

Patch Set 3 : Add a very useful hint about relation ordering. #

Patch Set 4 : Add a very useful hint about relation ordering. #

Patch Set 5 : Add a very useful hint about relation ordering. #

Patch Set 6 : Add a very useful hint about relation ordering. #

Patch Set 7 : Add a very useful hint about relation ordering. #

Patch Set 8 : Add a very useful hint about relation ordering. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -6 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/lib/proof.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	charmworld/lib/tests/test_proof.py	View	1	2 chunks	+30 lines, -4 lines	0 comments	Download
M	charmworld/views/tests/test_proof.py	View		2 chunks	+37 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rick.harding

LGTM with the one question on the assumption in the hint. https://codereview.appspot.com/54560044/diff/1/charmworld/lib/proof.py File charmworld/lib/proof.py (right): ...

10 years, 3 months ago (2014-01-20 20:53:31 UTC) #2

benji-york

10 years, 3 months ago (2014-01-21 13:47:49 UTC) #4

Fixed bug found in review.

https://codereview.appspot.com/54560044/diff/1/charmworld/lib/proof.py
File charmworld/lib/proof.py (right):

https://codereview.appspot.com/54560044/diff/1/charmworld/lib/proof.py#newcode96
charmworld/lib/proof.py:96: raise ProofError(
On 2014/01/20 20:53:31, rick.harding wrote:
> Doesn't this hint need to account for the case of non matching types? 

Indeed!  I've fixed this and added a test.

Expand All Messages | Collapse All Messages