Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(458)

Issue 5452060: code review 5452060: syscall: add constants for flock() system call under Linux.

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by spadaccio
Modified:
14 years, 1 month ago
Reviewers:
mikio
CC:
golang-dev, mikio, dsymonds, bradfitzgoog, dsymonds1
Visibility:
Public.

Description

syscall: add constants for flock() system call under Linux. The values have been generated only for the i386 and amd64 architectures.

Patch Set 1 #

Patch Set 2 : diff -r 778c06919be6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 778c06919be6 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 778c06919be6 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/pkg/syscall/mkerrors.sh View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_386.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_amd64.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9
spadaccio
Hello golang-dev@googlegroups.com (cc: bradfitz@google.com, dsymonds@google.com, golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 1 month ago (2011-12-06 22:53:23 UTC) #1
mikio
http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh#newcode26 src/pkg/syscall/mkerrors.sh:26: #include <sys/file.h> might be better not only for Linux. ...
14 years, 1 month ago (2011-12-07 05:25:10 UTC) #2
spadaccio
Hello golang-dev@googlegroups.com, mikioh.mikioh@gmail.com (cc: bradfitz@google.com, dsymonds@google.com, golang-dev@googlegroups.com), Please take another look.
14 years, 1 month ago (2011-12-07 12:25:57 UTC) #3
spadaccio
http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh#newcode26 src/pkg/syscall/mkerrors.sh:26: #include <sys/file.h> On 2011/12/07 05:25:11, mikioh wrote: > might ...
14 years, 1 month ago (2011-12-07 12:27:13 UTC) #4
mikio
LGTM
14 years, 1 month ago (2011-12-07 13:50:43 UTC) #5
mikio
Hello, Does anybody his colleague be able to proceed corporate contributor license agreement for him? ...
14 years, 1 month ago (2011-12-08 04:47:44 UTC) #6
dsymonds
On Thu, Dec 8, 2011 at 3:47 PM, <mikioh.mikioh@gmail.com> wrote: > Does anybody his colleague ...
14 years, 1 month ago (2011-12-08 04:49:41 UTC) #7
mikio
Thank you. On 2011/12/08 04:49:41, dsymonds wrote: > On Thu, Dec 8, 2011 at 3:47 ...
14 years, 1 month ago (2011-12-08 06:11:56 UTC) #8
mikio
14 years, 1 month ago (2011-12-08 06:12:14 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=5190380293e8 ***

syscall: add constants for flock() system call under Linux.

The values have been generated only for the i386 and amd64 architectures.

R=golang-dev, mikioh.mikioh, dsymonds
CC=bradfitz, dsymonds, golang-dev
http://codereview.appspot.com/5452060

Committer: Mikio Hara <mikioh.mikioh@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b