code review 5452060: syscall: add constants for flock() system call under Linux.

syscall: add constants for flock() system call under Linux.

The values have been generated only for the i386 and amd64 architectures.

[spadaccio, 2011-12-06 22:53:23]

Hello golang-dev@googlegroups.com (cc: bradfitz@google.com, dsymonds@google.com,
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2011-12-07 05:25:10]

http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh
File src/pkg/syscall/mkerrors.sh (right):

http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh#n...
src/pkg/syscall/mkerrors.sh:26: #include <sys/file.h>
might be better not only for Linux.

e.g.,
includes='
#include <dirent.h>
#include <errno.h>
#include <fcntl.h>
#include <sys/file.h>
#include <sys/resource.h>
#include <sys/socket.h>
#include <sys/types.h>
#include <netinet/in.h>
#include <netinet/ip.h>
#include <netinet/ip6.h>
#include <netinet/tcp.h>
#include <signal.h>
#include <sys/signal.h>
'

[spadaccio, 2011-12-07 12:25:57]

Hello golang-dev@googlegroups.com, mikioh.mikioh@gmail.com (cc:
bradfitz@google.com, dsymonds@google.com, golang-dev@googlegroups.com),

Please take another look.

[spadaccio, 2011-12-07 12:27:13]

http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh
File src/pkg/syscall/mkerrors.sh (right):

http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh#n...
src/pkg/syscall/mkerrors.sh:26: #include <sys/file.h>
On 2011/12/07 05:25:11, mikioh wrote:
> might be better not only for Linux.
> 
> e.g.,
> includes='
> #include <dirent.h>
> #include <errno.h>
> #include <fcntl.h>
> #include <sys/file.h>
> #include <sys/resource.h>
> #include <sys/socket.h>
> #include <sys/types.h>
> #include <netinet/in.h>
> #include <netinet/ip.h>
> #include <netinet/ip6.h>
> #include <netinet/tcp.h>
> #include <signal.h>
> #include <sys/signal.h>
> '

Done.

[mikio, 2011-12-07 13:50:43]

LGTM

[mikio, 2011-12-08 04:47:44]

Hello,

Does anybody his colleague be able to proceed corporate contributor 
license agreement for him?

Thx.

[dsymonds, 2011-12-08 04:49:41]

On Thu, Dec 8, 2011 at 3:47 PM,  <mikioh.mikioh@gmail.com> wrote:

> Does anybody his colleague be able to proceed corporate contributor
> license agreement for him?

I'll get it.

[mikio, 2011-12-08 06:11:56]

Thank you.

On 2011/12/08 04:49:41, dsymonds wrote:
> On Thu, Dec 8, 2011 at 3:47 PM,  <mailto:mikioh.mikioh@gmail.com> wrote:
> 
> > Does anybody his colleague be able to proceed corporate contributor
> > license agreement for him?
> 
> I'll get it.

[mikio, 2011-12-08 06:12:14]

*** Submitted as http://code.google.com/p/go/source/detail?r=5190380293e8 ***

syscall: add constants for flock() system call under Linux.

The values have been generated only for the i386 and amd64 architectures.

R=golang-dev, mikioh.mikioh, dsymonds
CC=bradfitz, dsymonds, golang-dev
http://codereview.appspot.com/5452060

Committer: Mikio Hara <mikioh.mikioh@gmail.com>