code review 5450119: syscall: return error, not uintptr, when function retur...

syscall: return error, not uintptr, when function returns error

[brainman, 2011-12-07 04:25:37]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-12-07 18:40:49]

LGTM

http://codereview.appspot.com/5450119/diff/3/src/pkg/syscall/syscall_windows.go
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/5450119/diff/3/src/pkg/syscall/syscall_windows....
src/pkg/syscall/syscall_windows.go:83: // deal with special go errors
I would not complain if the special Go errors had a
different type, like GoError.

[brainman, 2011-12-08 00:16:54]

http://codereview.appspot.com/5450119/diff/3/src/pkg/syscall/syscall_windows.go
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/5450119/diff/3/src/pkg/syscall/syscall_windows....
src/pkg/syscall/syscall_windows.go:83: // deal with special go errors
Are you talking about E2BIG, EACCES, EADDRINUSE, EADDRNOTAVAIL and so on? If
yes, then they are Errno at the moment, and I see no problem with that. Windows
allows applications to create their own specific errors (as long as their errno
is greater then APPLICATION_ERROR), and that is what these are. Why would you
want to see them separate from Errno?

Regardless, I would like to submit this CL as is and worry about GoErrors in the
future CL.

[brainman, 2011-12-08 01:07:31]

*** Submitted as http://code.google.com/p/go/source/detail?r=fafcd328da73 ***

syscall: return error, not uintptr, when function returns error

R=rsc
CC=golang-dev
http://codereview.appspot.com/5450119